Skip to content

Commit

Permalink
[LLDB] Don't forcefully initialize the process trace plugin (#71455)
Browse files Browse the repository at this point in the history
This was causing some process to wrongfully be handled by ProcessTrace.
    
The only place this was being used is in the intel pt plugin, but it
doesn't even build anymore, so I'm sure no one is using it.
  • Loading branch information
walter-erquinigo authored Nov 7, 2023
1 parent 3c356ee commit 555a71b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
3 changes: 0 additions & 3 deletions lldb/source/API/SystemInitializerFull.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,6 @@ llvm::Error SystemInitializerFull::Initialize() {
#define LLDB_PLUGIN(p) LLDB_PLUGIN_INITIALIZE(p);
#include "Plugins/Plugins.def"

// Initialize plug-ins in core LLDB
ProcessTrace::Initialize();

// Scan for any system or user LLDB plug-ins
PluginManager::Initialize();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,11 @@ TraceIntelPTBundleLoader::CreateEmptyProcess(lldb::pid_t pid,
ParsedProcess parsed_process;
parsed_process.target_sp = target_sp;

ProcessSP process_sp = target_sp->CreateProcess(
/*listener*/ nullptr, "trace",
/*crash_file*/ nullptr,
/*can_connect*/ false);
// This should instead try to directly create an instance of ProcessTrace.
// ProcessSP process_sp = target_sp->CreateProcess(
// /*listener*/ nullptr, "trace",
// /*crash_file*/ nullptr,
// /*can_connect*/ false);

process_sp->SetID(static_cast<lldb::pid_t>(pid));

Expand Down

0 comments on commit 555a71b

Please sign in to comment.