Skip to content

Commit 467b1ce

Browse files
committed
Address review feedback
1 parent bc79e3a commit 467b1ce

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

.github/workflows/llvm-project-tests.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ on:
1010
required: false
1111
projects:
1212
required: false
13-
experimental_targets:
13+
extra_cmake_args:
1414
required: false
1515
workflow_call:
1616
inputs:
@@ -22,7 +22,7 @@ on:
2222
required: true
2323
type: string
2424

25-
experimental_targets:
25+
extra_cmake_args:
2626
required: false
2727
type: string
2828

@@ -91,7 +91,7 @@ jobs:
9191
# This should be a no-op for non-mac OSes
9292
PKG_CONFIG_PATH: /usr/local/Homebrew/Library/Homebrew/os/mac/pkgconfig//12
9393
with:
94-
cmake_args: '-GNinja -DLLVM_ENABLE_PROJECTS="${{ inputs.projects }}" -DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD="${{ inputs.experimental_targets }}" -DCMAKE_BUILD_TYPE=Release -DLLDB_INCLUDE_TESTS=OFF -DCMAKE_C_COMPILER_LAUNCHER=sccache -DCMAKE_CXX_COMPILER_LAUNCHER=sccache'
94+
cmake_args: '-GNinja -DLLVM_ENABLE_PROJECTS="${{ inputs.projects }}" -DCMAKE_BUILD_TYPE=Release -DLLDB_INCLUDE_TESTS=OFF -DCMAKE_C_COMPILER_LAUNCHER=sccache -DCMAKE_CXX_COMPILER_LAUNCHER=sccache ${{ inputs.extra_cmake_args }}'
9595
build_target: '${{ inputs.build_target }}'
9696

9797
- name: Build and Test libclc

.github/workflows/spirv-tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,5 @@ jobs:
2424
uses: ./.github/workflows/llvm-project-tests.yml
2525
with:
2626
build_target: check-llvm-codegen-spirv
27-
projects: clang
28-
experimental_targets: SPIRV
27+
projects:
28+
extra_cmake_args: '-DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD="SPIRV"'

0 commit comments

Comments
 (0)