[Clang][ASan] Correct AsanDtorKindToString to return non-void in default case

Kostya Kortchinsky · Kostya Kortchinsky · commit 41751b637317 · 2021-02-25T15:32:18.000-08:00
Post D96572, a warning started showing up for me: `clang/lib/Basic/Sanitizers.cpp:73:1: warning: control reaches end of non-void function [-Wreturn-type]` So this adds a default to the case to return invalid, which seems appropriate, and appears to correct the issue. Differential Revision: https://reviews.llvm.org/D97496
diff --git a/clang/lib/Basic/Sanitizers.cpp b/clang/lib/Basic/Sanitizers.cpp
@@ -70,6 +70,7 @@ StringRef AsanDtorKindToString(llvm::AsanDtorKind kind) {
   case llvm::AsanDtorKind::Invalid:
     return "invalid";
   }
+  return "invalid";
 }
 
 llvm::AsanDtorKind AsanDtorKindFromString(StringRef kindStr) {

Original file line number	Diff line number	Diff line change
`@@ -70,6 +70,7 @@ StringRef AsanDtorKindToString(llvm::AsanDtorKind kind) {`
`70`	`70`	`case llvm::AsanDtorKind::Invalid:`
`71`	`71`	`return "invalid";`
`72`	`72`	`}`
	`73`	`+ return "invalid";`
`73`	`74`	`}`
`74`	`75`
`75`	`76`	`llvm::AsanDtorKind AsanDtorKindFromString(StringRef kindStr) {`