Skip to content

Commit 37ad65f

Browse files
authored
[mlir][arith] Remove some e2e tests (#112012)
I am removing the recently added integration test for various Arith Ops. These operations and their lowerings are effectively already verified by the Arith-to-LLVM conversion tests in: * "mlir/test/Conversion/ArithToLLVM/arith-to-llvm.mlir" I've noticed that a few variants of `arith.cmpi` were missing in that file - those are added here as well. This is a follow-up for this discussion: * #92272 See also the recent update to our guidelines on e2e tests in MLIR: * llvm/mlir-www#203
1 parent 2442310 commit 37ad65f

File tree

4 files changed

+26
-395
lines changed

4 files changed

+26
-395
lines changed

mlir/test/Conversion/ArithToLLVM/arith-to-llvm.mlir

Lines changed: 26 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -46,33 +46,45 @@ func.func @ops(f32, f32, i32, i32, f64) -> (f32, i32) {
4646
%1 = arith.subi %arg2, %arg3: i32
4747
// CHECK: = llvm.icmp "slt" %arg2, %1 : i32
4848
%2 = arith.cmpi slt, %arg2, %1 : i32
49+
// CHECK: = llvm.icmp "sle" %arg2, %1 : i32
50+
%3 = arith.cmpi sle, %arg2, %1 : i32
51+
// CHECK: = llvm.icmp "sgt" %arg2, %1 : i32
52+
%4 = arith.cmpi sgt, %arg2, %1 : i32
53+
// CHECK: = llvm.icmp "ult" %arg2, %1 : i32
54+
%5 = arith.cmpi ult, %arg2, %1 : i32
55+
// CHECK: = llvm.icmp "ule" %arg2, %1 : i32
56+
%6 = arith.cmpi ule, %arg2, %1 : i32
57+
// CHECK: = llvm.icmp "ugt" %arg2, %1 : i32
58+
%7 = arith.cmpi ugt, %arg2, %1 : i32
59+
// CHECK: = llvm.icmp "eq" %arg2, %1 : i32
60+
%8 = arith.cmpi eq, %arg2, %1 : i32
4961
// CHECK: = llvm.sdiv %arg2, %arg3 : i32
50-
%3 = arith.divsi %arg2, %arg3 : i32
62+
%9 = arith.divsi %arg2, %arg3 : i32
5163
// CHECK: = llvm.udiv %arg2, %arg3 : i32
52-
%4 = arith.divui %arg2, %arg3 : i32
64+
%10 = arith.divui %arg2, %arg3 : i32
5365
// CHECK: = llvm.srem %arg2, %arg3 : i32
54-
%5 = arith.remsi %arg2, %arg3 : i32
66+
%11 = arith.remsi %arg2, %arg3 : i32
5567
// CHECK: = llvm.urem %arg2, %arg3 : i32
56-
%6 = arith.remui %arg2, %arg3 : i32
68+
%12 = arith.remui %arg2, %arg3 : i32
5769
// CHECK: = llvm.fdiv %arg0, %arg1 : f32
58-
%8 = arith.divf %arg0, %arg1 : f32
70+
%13 = arith.divf %arg0, %arg1 : f32
5971
// CHECK: = llvm.frem %arg0, %arg1 : f32
60-
%9 = arith.remf %arg0, %arg1 : f32
72+
%14 = arith.remf %arg0, %arg1 : f32
6173
// CHECK: = llvm.and %arg2, %arg3 : i32
62-
%10 = arith.andi %arg2, %arg3 : i32
74+
%15 = arith.andi %arg2, %arg3 : i32
6375
// CHECK: = llvm.or %arg2, %arg3 : i32
64-
%11 = arith.ori %arg2, %arg3 : i32
76+
%16 = arith.ori %arg2, %arg3 : i32
6577
// CHECK: = llvm.xor %arg2, %arg3 : i32
66-
%12 = arith.xori %arg2, %arg3 : i32
78+
%17 = arith.xori %arg2, %arg3 : i32
6779
// CHECK: = llvm.mlir.constant(7.900000e-01 : f64) : f64
68-
%15 = arith.constant 7.9e-01 : f64
80+
%18 = arith.constant 7.9e-01 : f64
6981
// CHECK: = llvm.shl %arg2, %arg3 : i32
70-
%16 = arith.shli %arg2, %arg3 : i32
82+
%19 = arith.shli %arg2, %arg3 : i32
7183
// CHECK: = llvm.ashr %arg2, %arg3 : i32
72-
%17 = arith.shrsi %arg2, %arg3 : i32
84+
%20 = arith.shrsi %arg2, %arg3 : i32
7385
// CHECK: = llvm.lshr %arg2, %arg3 : i32
74-
%18 = arith.shrui %arg2, %arg3 : i32
75-
return %0, %4 : f32, i32
86+
%21 = arith.shrui %arg2, %arg3 : i32
87+
return %0, %10 : f32, i32
7688
}
7789

7890
// Checking conversion of index types to integers using i1, assuming no target

mlir/test/Integration/Dialect/Arith/CPU/addition.mlir

Lines changed: 0 additions & 88 deletions
This file was deleted.

mlir/test/Integration/Dialect/Arith/CPU/comparison.mlir

Lines changed: 0 additions & 174 deletions
This file was deleted.

0 commit comments

Comments
 (0)