Skip to content

Commit 23f8fac

Browse files
MaskRayMaskRay
committed
Revert "Repply#2 "[RemoveDIs] Load into new debug info format by default in LLVM (#89799)""
This reverts commit 91446e2 and a unittest followup 1530f31 (#90476). In a stage-2 -flto=thin -gsplit-dwarf -g -fdebug-info-for-profiling -fprofile-sample-use= build of clang, a ThinLTO backend compile has assertion failures: Global is external, but doesn't have external or weak linkage! ptr @_ZN5clang12ast_matchers8internal18makeAllOfCompositeINS_8QualTypeEEENS1_15BindableMatcherIT_EEN4llvm8ArrayRefIPKNS1_7MatcherIS5_EEEE function declaration may only have a unique !dbg attachment ptr @_ZN5clang12ast_matchers8internal18makeAllOfCompositeINS_8QualTypeEEENS1_15BindableMatcherIT_EEN4llvm8ArrayRefIPKNS1_7MatcherIS5_EEEE The failures somehow go away if -fprofile-sample-use= is removed.
1 parent c99d115 commit 23f8fac

19 files changed

+248
-233
lines changed

‎llvm/docs/ReleaseNotes.rst

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -189,13 +189,6 @@ Changes to the Metadata Info
189189
Changes to the Debug Info
190190
---------------------------------
191191

192-
* LLVM has switched from using debug intrinsics internally to using debug
193-
records by default. This should happen transparently when using the DIBuilder
194-
to construct debug variable information, but will require changes for any code
195-
that interacts with debug intrinsics directly. Debug intrinsics will only be
196-
supported on a best-effort basis from here onwards; for more information, see
197-
the `migration docs <https://llvm.org/docs/RemoveDIsDebugInfo.html>`_.
198-
199192
Changes to the LLVM tools
200193
---------------------------------
201194
* llvm-nm and llvm-objdump can now print symbol information from linked

‎llvm/include/llvm/AsmParser/LLParser.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -337,6 +337,7 @@ namespace llvm {
337337

338338
// Top-Level Entities
339339
bool parseTopLevelEntities();
340+
bool finalizeDebugInfoFormat(Module *M);
340341
void dropUnknownMetadataReferences();
341342
bool validateEndOfModule(bool UpgradeDebugInfo);
342343
bool validateEndOfIndex();

‎llvm/lib/AsmParser/LLParser.cpp

Lines changed: 18 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,23 @@ static std::string getTypeString(Type *T) {
7474
return Tmp.str();
7575
}
7676

77+
// Whatever debug info format we parsed, we should convert to the expected debug
78+
// info format immediately afterwards.
79+
bool LLParser::finalizeDebugInfoFormat(Module *M) {
80+
// We should have already returned an error if we observed both intrinsics and
81+
// records in this IR.
82+
assert(!(SeenNewDbgInfoFormat && SeenOldDbgInfoFormat) &&
83+
"Mixed debug intrinsics/records seen without a parsing error?");
84+
if (PreserveInputDbgFormat == cl::boolOrDefault::BOU_TRUE) {
85+
UseNewDbgInfoFormat = SeenNewDbgInfoFormat;
86+
WriteNewDbgInfoFormatToBitcode = SeenNewDbgInfoFormat;
87+
WriteNewDbgInfoFormat = SeenNewDbgInfoFormat;
88+
} else if (M) {
89+
M->setIsNewDbgInfoFormat(false);
90+
}
91+
return false;
92+
}
93+
7794
/// Run: module ::= toplevelentity*
7895
bool LLParser::Run(bool UpgradeDebugInfo,
7996
DataLayoutCallbackTy DataLayoutCallback) {
@@ -91,7 +108,7 @@ bool LLParser::Run(bool UpgradeDebugInfo,
91108
}
92109

93110
return parseTopLevelEntities() || validateEndOfModule(UpgradeDebugInfo) ||
94-
validateEndOfIndex();
111+
validateEndOfIndex() || finalizeDebugInfoFormat(M);
95112
}
96113

97114
bool LLParser::parseStandaloneConstantValue(Constant *&C,
@@ -190,18 +207,6 @@ void LLParser::dropUnknownMetadataReferences() {
190207
bool LLParser::validateEndOfModule(bool UpgradeDebugInfo) {
191208
if (!M)
192209
return false;
193-
194-
// We should have already returned an error if we observed both intrinsics and
195-
// records in this IR.
196-
assert(!(SeenNewDbgInfoFormat && SeenOldDbgInfoFormat) &&
197-
"Mixed debug intrinsics/records seen without a parsing error?");
198-
if (PreserveInputDbgFormat == cl::boolOrDefault::BOU_TRUE) {
199-
UseNewDbgInfoFormat = SeenNewDbgInfoFormat;
200-
WriteNewDbgInfoFormatToBitcode = SeenNewDbgInfoFormat;
201-
WriteNewDbgInfoFormat = SeenNewDbgInfoFormat;
202-
M->setNewDbgInfoFormatFlag(SeenNewDbgInfoFormat);
203-
}
204-
205210
// Handle any function attribute group forward references.
206211
for (const auto &RAG : ForwardRefAttrGroups) {
207212
Value *V = RAG.first;
@@ -434,9 +439,6 @@ bool LLParser::validateEndOfModule(bool UpgradeDebugInfo) {
434439
UpgradeModuleFlags(*M);
435440
UpgradeSectionAttributes(*M);
436441

437-
if (PreserveInputDbgFormat != cl::boolOrDefault::BOU_TRUE)
438-
M->setIsNewDbgInfoFormat(UseNewDbgInfoFormat);
439-
440442
if (!Slots)
441443
return false;
442444
// Initialize the slot mapping.

‎llvm/lib/Bitcode/Reader/BitcodeReader.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4319,7 +4319,7 @@ Error BitcodeReader::parseModule(uint64_t ResumeBit,
43194319
if (PreserveInputDbgFormat != cl::boolOrDefault::BOU_TRUE) {
43204320
TheModule->IsNewDbgInfoFormat =
43214321
UseNewDbgInfoFormat &&
4322-
LoadBitcodeIntoNewDbgInfoFormat != cl::boolOrDefault::BOU_FALSE;
4322+
LoadBitcodeIntoNewDbgInfoFormat == cl::boolOrDefault::BOU_TRUE;
43234323
}
43244324

43254325
this->ValueTypeCallback = std::move(Callbacks.ValueType);

‎llvm/lib/IR/BasicBlock.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ template class llvm::SymbolTableListTraits<Instruction,
181181
BasicBlock::BasicBlock(LLVMContext &C, const Twine &Name, Function *NewParent,
182182
BasicBlock *InsertBefore)
183183
: Value(Type::getLabelTy(C), Value::BasicBlockVal),
184-
IsNewDbgInfoFormat(UseNewDbgInfoFormat), Parent(nullptr) {
184+
IsNewDbgInfoFormat(false), Parent(nullptr) {
185185

186186
if (NewParent)
187187
insertInto(NewParent, InsertBefore);

‎llvm/lib/IR/DebugProgramInstruction.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -366,8 +366,8 @@ void DbgVariableRecord::setKillLocation() {
366366
}
367367

368368
bool DbgVariableRecord::isKillLocation() const {
369-
return (!hasArgList() && isa<MDNode>(getRawLocation())) ||
370-
(getNumVariableLocationOps() == 0 && !getExpression()->isComplex()) ||
369+
return (getNumVariableLocationOps() == 0 &&
370+
!getExpression()->isComplex()) ||
371371
any_of(location_ops(), [](Value *V) { return isa<UndefValue>(V); });
372372
}
373373

‎llvm/lib/IR/Function.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,6 @@ static cl::opt<unsigned> NonGlobalValueMaxNameSize(
8383
"non-global-value-max-name-size", cl::Hidden, cl::init(1024),
8484
cl::desc("Maximum size for the name of non-global values."));
8585

86-
extern cl::opt<bool> UseNewDbgInfoFormat;
87-
8886
void Function::convertToNewDbgValues() {
8987
IsNewDbgInfoFormat = true;
9088
for (auto &BB : *this) {
@@ -440,7 +438,7 @@ Function::Function(FunctionType *Ty, LinkageTypes Linkage, unsigned AddrSpace,
440438
: GlobalObject(Ty, Value::FunctionVal,
441439
OperandTraits<Function>::op_begin(this), 0, Linkage, name,
442440
computeAddrSpace(AddrSpace, ParentModule)),
443-
NumArgs(Ty->getNumParams()), IsNewDbgInfoFormat(UseNewDbgInfoFormat) {
441+
NumArgs(Ty->getNumParams()), IsNewDbgInfoFormat(false) {
444442
assert(FunctionType::isValidReturnType(getReturnType()) &&
445443
"invalid return type");
446444
setGlobalObjectSubClassData(0);

‎llvm/lib/IR/Module.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,6 @@
5454

5555
using namespace llvm;
5656

57-
extern cl::opt<bool> UseNewDbgInfoFormat;
58-
5957
//===----------------------------------------------------------------------===//
6058
// Methods to implement the globals and functions lists.
6159
//
@@ -74,7 +72,7 @@ template class llvm::SymbolTableListTraits<GlobalIFunc>;
7472
Module::Module(StringRef MID, LLVMContext &C)
7573
: Context(C), ValSymTab(std::make_unique<ValueSymbolTable>(-1)),
7674
ModuleID(std::string(MID)), SourceFileName(std::string(MID)), DL(""),
77-
IsNewDbgInfoFormat(UseNewDbgInfoFormat) {
75+
IsNewDbgInfoFormat(false) {
7876
Context.addModule(this);
7977
}
8078

‎llvm/tools/llvm-as/llvm-as.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -142,10 +142,11 @@ int main(int argc, char **argv) {
142142
}
143143

144144
// Convert to new debug format if requested.
145-
M->setIsNewDbgInfoFormat(UseNewDbgInfoFormat &&
146-
WriteNewDbgInfoFormatToBitcode);
147-
if (M->IsNewDbgInfoFormat)
145+
assert(!M->IsNewDbgInfoFormat && "Unexpectedly in new debug mode");
146+
if (UseNewDbgInfoFormat && WriteNewDbgInfoFormatToBitcode) {
147+
M->convertToNewDbgValues();
148148
M->removeDebugIntrinsicDeclarations();
149+
}
149150

150151
std::unique_ptr<ModuleSummaryIndex> Index = std::move(ModuleAndIndex.Index);
151152

‎llvm/tools/llvm-dis/llvm-dis.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ int main(int argc, char **argv) {
258258
// All that llvm-dis does is write the assembly to a file.
259259
if (!DontPrint) {
260260
if (M) {
261-
M->setIsNewDbgInfoFormat(WriteNewDbgInfoFormat);
261+
ScopedDbgInfoFormatSetter FormatSetter(*M, WriteNewDbgInfoFormat);
262262
if (WriteNewDbgInfoFormat)
263263
M->removeDebugIntrinsicDeclarations();
264264
M->print(Out->os(), Annotator.get(), PreserveAssemblyUseListOrder);

‎llvm/tools/llvm-link/llvm-link.cpp

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -489,6 +489,12 @@ int main(int argc, char **argv) {
489489
if (LoadBitcodeIntoNewDbgInfoFormat == cl::boolOrDefault::BOU_UNSET)
490490
LoadBitcodeIntoNewDbgInfoFormat = cl::boolOrDefault::BOU_TRUE;
491491

492+
// RemoveDIs debug-info transition: tests may request that we /try/ to use the
493+
// new debug-info format.
494+
if (TryUseNewDbgInfoFormat) {
495+
// Turn the new debug-info format on.
496+
UseNewDbgInfoFormat = true;
497+
}
492498
// Since llvm-link collects multiple IR modules together, for simplicity's
493499
// sake we disable the "PreserveInputDbgFormat" flag to enforce a single
494500
// debug info format.
@@ -550,7 +556,7 @@ int main(int argc, char **argv) {
550556
SetFormat(WriteNewDbgInfoFormat);
551557
Composite->print(Out.os(), nullptr, PreserveAssemblyUseListOrder);
552558
} else if (Force || !CheckBitcodeOutputToConsole(Out.os())) {
553-
SetFormat(UseNewDbgInfoFormat && WriteNewDbgInfoFormatToBitcode);
559+
SetFormat(WriteNewDbgInfoFormatToBitcode);
554560
WriteBitcodeToFile(*Composite, Out.os(), PreserveBitcodeUseListOrder);
555561
}
556562

‎llvm/unittests/Analysis/IRSimilarityIdentifierTest.cpp

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
//===----------------------------------------------------------------------===//
1313

1414
#include "llvm/Analysis/IRSimilarityIdentifier.h"
15-
#include "llvm/ADT/ScopeExit.h"
1615
#include "llvm/AsmParser/Parser.h"
1716
#include "llvm/IR/LLVMContext.h"
1817
#include "llvm/IR/Module.h"
@@ -23,11 +22,6 @@
2322
using namespace llvm;
2423
using namespace IRSimilarity;
2524

26-
extern llvm::cl::opt<bool> UseNewDbgInfoFormat;
27-
extern cl::opt<cl::boolOrDefault> PreserveInputDbgFormat;
28-
extern bool WriteNewDbgInfoFormatToBitcode;
29-
extern cl::opt<bool> WriteNewDbgInfoFormat;
30-
3125
static std::unique_ptr<Module> makeLLVMModule(LLVMContext &Context,
3226
StringRef ModuleStr) {
3327
SMDiagnostic Err;
@@ -1312,18 +1306,19 @@ TEST(IRInstructionMapper, CallBrInstIllegal) {
13121306
ASSERT_GT(UnsignedVec[0], Mapper.IllegalInstrNumber);
13131307
}
13141308

1315-
// Checks that an debuginfo records are mapped to be invisible. Since they
1309+
// Checks that an debuginfo intrinsics are mapped to be invisible. Since they
13161310
// do not semantically change the program, they can be recognized as similar.
13171311
TEST(IRInstructionMapper, DebugInfoInvisible) {
13181312
StringRef ModuleString = R"(
13191313
define i32 @f(i32 %a, i32 %b) {
13201314
then:
1321-
%0 = add i32 %a, %b
1322-
#dbg_value(i32 0, !0, !0, !0)
1323-
%1 = add i32 %a, %b
1315+
%0 = add i32 %a, %b
1316+
call void @llvm.dbg.value(metadata !0)
1317+
%1 = add i32 %a, %b
13241318
ret i32 0
13251319
}
13261320

1321+
declare void @llvm.dbg.value(metadata)
13271322
!0 = distinct !{!"test\00", i32 10})";
13281323
LLVMContext Context;
13291324
std::unique_ptr<Module> M = makeLLVMModule(Context, ModuleString);
@@ -1919,19 +1914,19 @@ TEST(IRSimilarityCandidate, CheckRegionsDifferentTypes) {
19191914
ASSERT_FALSE(longSimCandCompare(InstrList));
19201915
}
19211916

1922-
// Check that debug records do not impact similarity. They are marked as
1917+
// Check that debug instructions do not impact similarity. They are marked as
19231918
// invisible.
19241919
TEST(IRSimilarityCandidate, IdenticalWithDebug) {
19251920
StringRef ModuleString = R"(
19261921
define i32 @f(i32 %a, i32 %b) {
19271922
bb0:
19281923
%0 = add i32 %a, %b
1929-
#dbg_value(i32 0, !0, !0, !0)
1924+
call void @llvm.dbg.value(metadata !0)
19301925
%1 = add i32 %b, %a
19311926
ret i32 0
19321927
bb1:
19331928
%2 = add i32 %a, %b
1934-
#dbg_value(i32 1, !1, !1, !1)
1929+
call void @llvm.dbg.value(metadata !1)
19351930
%3 = add i32 %b, %a
19361931
ret i32 0
19371932
bb2:
@@ -1940,6 +1935,7 @@ TEST(IRSimilarityCandidate, IdenticalWithDebug) {
19401935
ret i32 0
19411936
}
19421937

1938+
declare void @llvm.dbg.value(metadata)
19431939
!0 = distinct !{!"test\00", i32 10}
19441940
!1 = distinct !{!"test\00", i32 11})";
19451941
LLVMContext Context;

0 commit comments

Comments
 (0)