Skip to content

Commit 179d30f

Browse files
authored
Revert "[lldb] Make sure the process is stopped when computing the symbol context (#134757)" (#135408)
This reverts commit e84a804 because on Linux there seems to be a race around GetRunLock. See #134757 for more context.
1 parent c2939b9 commit 179d30f

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

lldb/source/Core/Statusline.cpp

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
#include "lldb/Host/StreamFile.h"
1313
#include "lldb/Interpreter/CommandInterpreter.h"
1414
#include "lldb/Symbol/SymbolContext.h"
15-
#include "lldb/Target/Process.h"
1615
#include "lldb/Target/StackFrame.h"
1716
#include "lldb/Utility/AnsiTerminal.h"
1817
#include "lldb/Utility/StreamString.h"
@@ -135,15 +134,8 @@ void Statusline::Redraw(bool update) {
135134
exe_ctx.SetTargetPtr(&m_debugger.GetSelectedOrDummyTarget());
136135

137136
SymbolContext symbol_ctx;
138-
if (ProcessSP process_sp = exe_ctx.GetProcessSP()) {
139-
// Check if the process is stopped, and if it is, make sure it remains
140-
// stopped until we've computed the symbol context.
141-
Process::StopLocker stop_locker;
142-
if (stop_locker.TryLock(&process_sp->GetRunLock())) {
143-
if (auto frame_sp = exe_ctx.GetFrameSP())
144-
symbol_ctx = frame_sp->GetSymbolContext(eSymbolContextEverything);
145-
}
146-
}
137+
if (auto frame_sp = exe_ctx.GetFrameSP())
138+
symbol_ctx = frame_sp->GetSymbolContext(eSymbolContextEverything);
147139

148140
StreamString stream;
149141
if (auto *format = m_debugger.GetStatuslineFormat())

0 commit comments

Comments
 (0)