Skip to content

Commit 163fe1d

Browse files
committed
[AArch64][SVE] Don't require 16-byte aligned SVE loads/stores with +strict-align
Instead, allow any alignment >= the element size (in bytes). This is all that is needed for vector loads even if unaligned accesses are disabled. See: https://developer.arm.com/documentation/ddi0602/2024-09/Shared-Pseudocode/aarch64-functions-memory?lang=en#impl-aarch64.Mem.read.3 Specifically: ``` // Check alignment on size of element accessed, not overall access size. constant integer alignment = if accdesc.ispair then size DIV 2 else size; ``` The `size` passed to `Mem` by SVE load/store instructions is the element size.
1 parent 3dbff90 commit 163fe1d

File tree

2 files changed

+74
-0
lines changed

2 files changed

+74
-0
lines changed

llvm/lib/Target/AArch64/AArch64ISelLowering.cpp

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2569,6 +2569,16 @@ MVT AArch64TargetLowering::getScalarShiftAmountTy(const DataLayout &DL,
25692569
bool AArch64TargetLowering::allowsMisalignedMemoryAccesses(
25702570
EVT VT, unsigned AddrSpace, Align Alignment, MachineMemOperand::Flags Flags,
25712571
unsigned *Fast) const {
2572+
2573+
// Allow SVE loads/stores where the alignment >= the size of the element type,
2574+
// even with +strict-align. The SVE loads/stores do not require memory to be
2575+
// aligned more than the element type even without unaligned accesses.
2576+
// Without already aligned loads/stores are forced to have 16-byte alignment,
2577+
// which is unnecessary and fails to build as TLI.expandUnalignedLoad() and
2578+
// TLI.expandUnalignedStore() don't yet support scalable vectors.
2579+
if (VT.isScalableVector() && Alignment >= Align(VT.getScalarSizeInBits() / 8))
2580+
return true;
2581+
25722582
if (Subtarget->requiresStrictAlign())
25732583
return false;
25742584

Lines changed: 64 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
1+
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 4
2+
; RUN: llc -mtriple=aarch64-linux-gnu -mattr=+sve < %s | FileCheck %s
3+
; RUN: llc -mtriple=aarch64-linux-gnu -mattr=+sve,+strict-align < %s | FileCheck %s
4+
5+
define void @nxv16i8(ptr %ldptr, ptr %stptr) {
6+
; CHECK-LABEL: nxv16i8:
7+
; CHECK: // %bb.0:
8+
; CHECK-NEXT: ptrue p0.b
9+
; CHECK-NEXT: ld1b { z0.b }, p0/z, [x0]
10+
; CHECK-NEXT: st1b { z0.b }, p0, [x1]
11+
; CHECK-NEXT: ret
12+
%l3 = load <vscale x 16 x i8>, ptr %ldptr, align 1
13+
store <vscale x 16 x i8> %l3, ptr %stptr, align 1
14+
ret void
15+
}
16+
17+
define void @nxv8i16(ptr %ldptr, ptr %stptr) {
18+
; CHECK-LABEL: nxv8i16:
19+
; CHECK: // %bb.0:
20+
; CHECK-NEXT: ptrue p0.h
21+
; CHECK-NEXT: ld1h { z0.h }, p0/z, [x0]
22+
; CHECK-NEXT: st1h { z0.h }, p0, [x1]
23+
; CHECK-NEXT: ret
24+
%l3 = load <vscale x 8 x i16>, ptr %ldptr, align 2
25+
store <vscale x 8 x i16> %l3, ptr %stptr, align 2
26+
ret void
27+
}
28+
29+
define void @nxv4i32(ptr %ldptr, ptr %stptr) {
30+
; CHECK-LABEL: nxv4i32:
31+
; CHECK: // %bb.0:
32+
; CHECK-NEXT: ptrue p0.s
33+
; CHECK-NEXT: ld1w { z0.s }, p0/z, [x0]
34+
; CHECK-NEXT: st1w { z0.s }, p0, [x1]
35+
; CHECK-NEXT: ret
36+
%l3 = load <vscale x 4 x i32>, ptr %ldptr, align 4
37+
store <vscale x 4 x i32> %l3, ptr %stptr, align 4
38+
ret void
39+
}
40+
41+
define void @nxv2i64(ptr %ldptr, ptr %stptr) {
42+
; CHECK-LABEL: nxv2i64:
43+
; CHECK: // %bb.0:
44+
; CHECK-NEXT: ptrue p0.d
45+
; CHECK-NEXT: ld1d { z0.d }, p0/z, [x0]
46+
; CHECK-NEXT: st1d { z0.d }, p0, [x1]
47+
; CHECK-NEXT: ret
48+
%l3 = load <vscale x 2 x i64>, ptr %ldptr, align 8
49+
store <vscale x 2 x i64> %l3, ptr %stptr, align 8
50+
ret void
51+
}
52+
53+
; FIXME: Support TLI.expandUnalignedLoad()/TLI.expandUnalignedStore() for SVE.
54+
; define void @unaligned_nxv2i64(ptr %ldptr, ptr %stptr) {
55+
; ; CHECK-LABEL: nxv2i64:
56+
; ; CHECK: // %bb.0:
57+
; ; CHECK-NEXT: ptrue p0.d
58+
; ; CHECK-NEXT: ld1d { z0.d }, p0/z, [x0]
59+
; ; CHECK-NEXT: st1d { z0.d }, p0, [x1]
60+
; ; CHECK-NEXT: ret
61+
; %l3 = load <vscale x 2 x i64>, ptr %ldptr, align 4
62+
; store <vscale x 2 x i64> %l3, ptr %stptr, align 4
63+
; ret void
64+
; }

0 commit comments

Comments
 (0)