Skip to content

Commit 0fddfac

Browse files
committed
Remove overloads
We will add the overloads in a seperate patch.
1 parent 8478001 commit 0fddfac

File tree

2 files changed

+0
-51
lines changed

2 files changed

+0
-51
lines changed

libcxx/include/__math/traits.h

Lines changed: 0 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -38,48 +38,6 @@ _LIBCPP_NODISCARD inline
3838
return __builtin_signbit(__x);
3939
}
4040

41-
_LIBCPP_NODISCARD inline _LIBCPP_CONSTEXPR_SINCE_CXX23 _LIBCPP_HIDE_FROM_ABI
42-
#ifdef _LIBCPP_PREFERRED_OVERLOAD
43-
_LIBCPP_PREFERRED_OVERLOAD
44-
#endif
45-
bool
46-
signbit(float __x) _NOEXCEPT {
47-
// TODO(LLVM 22): Remove `__builtin_copysign`-workaround once support for Clang 19 is dropped.
48-
#if !__has_constexpr_builtin(__builtin_signbit) && _LIBCPP_STD_VER >= 23
49-
return __builtin_copysign(1.0, __x) == -1.0;
50-
#else
51-
return __builtin_signbit(__x);
52-
#endif
53-
}
54-
55-
_LIBCPP_NODISCARD inline _LIBCPP_CONSTEXPR_SINCE_CXX23 _LIBCPP_HIDE_FROM_ABI
56-
#ifdef _LIBCPP_PREFERRED_OVERLOAD
57-
_LIBCPP_PREFERRED_OVERLOAD
58-
#endif
59-
bool
60-
signbit(double __x) _NOEXCEPT {
61-
// TODO(LLVM 22): Remove `__builtin_copysign`-workaround once support for Clang 19 is dropped.
62-
#if !__has_constexpr_builtin(__builtin_signbit) && _LIBCPP_STD_VER >= 23
63-
return __builtin_copysign(1.0, __x) == -1.0;
64-
#else
65-
return __builtin_signbit(__x);
66-
#endif
67-
}
68-
69-
_LIBCPP_NODISCARD inline _LIBCPP_CONSTEXPR_SINCE_CXX23 _LIBCPP_HIDE_FROM_ABI
70-
#ifdef _LIBCPP_PREFERRED_OVERLOAD
71-
_LIBCPP_PREFERRED_OVERLOAD
72-
#endif
73-
bool
74-
signbit(long double __x) _NOEXCEPT {
75-
// TODO(LLVM 22): Remove `__builtin_copysign`-workaround once support for Clang 19 is dropped.
76-
#if !__has_constexpr_builtin(__builtin_signbit) && _LIBCPP_STD_VER >= 23
77-
return __builtin_copysign(1.0, __x) == -1.0;
78-
#else
79-
return __builtin_signbit(__x);
80-
#endif
81-
}
82-
8341
template <class _A1, __enable_if_t<is_integral<_A1>::value && is_signed<_A1>::value, int> = 0>
8442
_LIBCPP_NODISCARD inline _LIBCPP_CONSTEXPR_SINCE_CXX23 _LIBCPP_HIDE_FROM_ABI bool signbit(_A1 __x) _NOEXCEPT {
8543
return __x < 0;

libcxx/test/std/numerics/c.math/signbit.pass.cpp

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -79,14 +79,5 @@ int main(int, char**) {
7979
types::for_each(types::floating_point_types(), TestFloat());
8080
types::for_each(types::integral_types(), TestInt());
8181

82-
// Make sure we can call `std::signbit` with convertible types. This checks
83-
// whether overloads for all cv-unqualified floating-point types are working
84-
// as expected.
85-
{
86-
assert(!std::signbit(ConvertibleTo<float>()));
87-
assert(!std::signbit(ConvertibleTo<double>()));
88-
assert(!std::signbit(ConvertibleTo<long double>()));
89-
}
90-
9182
return 0;
9283
}

0 commit comments

Comments
 (0)