[Dexter] Fix incorrect substitution errors in clang-cl builder

Following 262520a, tests on windows bots began failing due to an incorrect
substitution in the previous patch, where clang-cl was used instead of
clang_cl.

Also fixes an inconsistency in the builders used for some of the tests
in 'dexter-tests', where %clang++ was used for some tests and %clang for
tests that should have identical RUN lines.

Author: SLTozer

cross-project-tests/debuginfo-tests/dexter-tests/global-constant.cpp

@@ -1,6 +1,6 @@
 // REQUIRES: system-windows
 //
-// RUN: %clang-cl /Z7 /Zi %s -o %t
+// RUN: %clang_cl /Z7 /Zi %s -o %t
 // RUN: %dexter --fail-lt 1.0 -w --binary %t --debugger 'dbgeng' -- %s
 
 // Check that global constants have debug info.

cross-project-tests/debuginfo-tests/dexter-tests/hello.c

@@ -1,6 +1,6 @@
 // REQUIRES: system-windows
 //
-// RUN: %clang-cl /Z7 /Zi %s -o %t
+// RUN: %clang_cl /Z7 /Zi %s -o %t
 // RUN: %dexter --fail-lt 1.0 -w --binary %t --debugger 'dbgeng' -- %s
 
 #include <stdio.h>

cross-project-tests/debuginfo-tests/dexter-tests/inline-line-gap.cpp

@@ -1,9 +1,9 @@
 // REQUIRES: system-windows
 //
-// RUN: %clang-cl /Od /Z7 /Zi %s -o %t
+// RUN: %clang_cl /Od /Z7 /Zi %s -o %t
 // RUN: %dexter --fail-lt 1.0 -w --binary %t --debugger 'dbgeng' -- %s
 //
-// RUN: %clang-cl /O2 /Z7 /Zi %s -o %t
+// RUN: %clang_cl /O2 /Z7 /Zi %s -o %t
 // RUN: %dexter --fail-lt 1.0 -w --binary %t \
 // RUN:      --debugger 'dbgeng' -- %s
 

cross-project-tests/debuginfo-tests/dexter-tests/nrvo.cpp

@@ -3,7 +3,7 @@
 //
 // REQUIRES: system-windows
 //
-// RUN: %clang-cl /Z7 /Zi %s -o %t
+// RUN: %clang_cl /Z7 /Zi %s -o %t
 // RUN: %dexter --fail-lt 1.0 -w --binary %t --debugger 'dbgeng' -- %s
 
 struct string {

cross-project-tests/debuginfo-tests/dexter-tests/optnone-vectors-and-functions.cpp

@@ -1,7 +1,7 @@
-// RUN: %clang -O2 -g %s -o %t
+// RUN: %clang++ -O2 -g %s -o %t
 // RUN: %dexter --fail-lt 1.0 -w \
 // RUN:     --binary %t --debugger 'lldb' -v -- %s
-// RUN: %clang -O0 -g %s -o %t
+// RUN: %clang++ -O0 -g %s -o %t
 // RUN: %dexter --fail-lt 1.0 -w \
 // RUN:     --binary %t --debugger 'lldb' -- %s
 

cross-project-tests/debuginfo-tests/dexter-tests/realigned-frame.cpp

@@ -1,6 +1,6 @@
 // REQUIRES: system-windows
 //
-// RUN: %clang-cl /Z7 /Zi %s -o %t
+// RUN: %clang_cl /Z7 /Zi %s -o %t
 // RUN: %dexter --fail-lt 1.0 -w --binary %t --debugger 'dbgeng' -- %s
 
 // From https://llvm.org/pr38857, where we had issues with stack realignment.

cross-project-tests/lit.cfg.py

@@ -123,7 +123,7 @@ def configure_dexter_substitutions():
     if platform.system() == "Windows":
         # The Windows builder script uses lld.
         dependencies = ["clang", "lld-link"]
-        dexter_regression_test_builder = "clang-cl"
+        dexter_regression_test_builder = "clang_cl"
         dexter_regression_test_debugger = "dbgeng"
         dexter_regression_test_flags = "/Zi /Od"
     else: