PR for llvm/llvm-project#65982 #703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to be failing tests in |
|
ping @antoniofrighetto |
|
also cc @AaronBallman @cor3ntin @erichkeene is this good to merge into 17.0.1 when the tests are passing? |
|
@tru, we need to backport llvm/llvm-project@c990d94 as well. That solves the failing test. |
|
@ormris in the original issue run |
|
Yeah, I think this is reasonable to backport into 17.0.1 once we have the tests passing. |
An assertion issue that arose when handling union member access with virtual base class has been addressed. As pointed out by @zygoloid, there is no need for further derived-to-base analysis in this instance, so we can bail out upon encountering a virtual base class. Minor refinement on the function name as we might not be handling a union. Reported-By: ormris Fixes: llvm/llvm-project#65982 (cherry picked from commit 660876a4019b81b5a7427a3dcec5ce8c39cd1ee0)
(cherry picked from commit c990d9444350ef583c6d53e84d9c10cebbf65532)
llvmbot
force-pushed
the
llvm-issue65982
branch
from
65a1518 to
df3e2c4
Compare
|
Is this good to go now? |
|
@tru, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves llvm/llvm-project#65982