Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds padding for union type, which is necessary in some cases (e.g. proper offset computation for an element of an array).
The previous discussion is here #1281
The idea is to add a notion about padding in the
StructType
in the same fashion as it's done for packed structures - as a bool argument in the constructor.Now we can compute the proper union type size as a size of the largest element + size of padding type.
There are some downsides though - I had to add this
padded
word in many places. So take a look please!There are many tests fixed and one new -
union-padding