[SCFToCalyx] Modify top-level function in place and propagate external memory allocations #8446
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch refactors the logic when there are
memref
type function arguments in the top-level function (because Calyx only supports interacting with memory data if that memory is allocated using@external
and does not support function argument memory data passing).We used to create a new top-level function, which does nothing but
invoke
ing the old top-level function. This approach is fine semantically, but recently @ayakayorihiro discovered that this prevents the static inference from inferencing the number of cycles in the Calyx project: calyxir/calyx#2452.As a solution, we can just modify the top-level function in-place by moving those
memref
function arguments to explicitmemref.alloc
s in the function body.Moreover, this patch also supports propagating external memory allocations from non-top-level functions to the top-level function because of the constraint in the Calyx project: https://github.com/calyxir/calyx/blob/50f817f9991df4fa87f2178222ba45a026aba549/calyx/opt/src/passes/well_formed.rs#L185