[FIRRTL][LowerDPI] Lower FIRRTL vector to an open array type #7305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uenoku
force-pushed
the
dev/hidetou/dpi-firrtl-intrinsic
branch
2 times, most recently
from
b15d9c0
to
eb70a6d
Compare
Previously a FIRRTL vector was lowered into a packed array and there was no way to generate an open array. This PR chagnes to use unpacked open array which is supported by several tools (at least verilator and vcs)
uenoku
force-pushed
the
dev/hidetou/dpi-firrtl-intrinsic
branch
from
eb70a6d
to
bc8cd49
Compare
uenoku
changed the title
fabianschuiki
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
I think this makes sense!
If I recall correctly, passing packed arrays through DPI directly can have weird memory layouts that makes it difficult to extract elements on the C side (because of the bit-dense packing in SV). Making arrays always go through an open array conversion where the C side can easily reason about the dimensions sounds like a good idea 👍
|
Looking forward to adopt this PR:) wish it can be used for deduping a massive DPI call of interface with different parameters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a FIRRTL vector was lowered into a packed array and there was no way
to generate an open array. This PR chagnes to use unpacked open array which is
supported by several tools (at least verilator and vcs)