[LowerClasses] Ensure classes are instantiated by an object. #7072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uenoku
reviewed
May 22, 2024
Comment on lines
+894
to
+888
| bool needsClone = false; | ||
| if (auto instance = dyn_cast<InstanceOp>(op)) | ||
| needsClone = shouldCreateClass(instance.getReferencedModuleNameAttr()); |
There was a problem hiding this comment.
I think you can lookup FModuleLike through InstanceGraph and probably we don't have to change the type
There was a problem hiding this comment.
This can avoid avoid an unnecessary instance graph lookup, as the module op is not required here. Querying just using the name seems better here.
prithayan
force-pushed
the
dev/pbarua/lower-classes
branch
from
0db1203
to
e68f7e0
Compare
prithayan
requested review from
darthscsi,
dtzSiFive and
seldridge
as code owners
mikeurbach
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LowerClasscreates an object for a corresponding instance only if the instantiated module has property ports.But a class can be created for a corresponding module based on other conditions like, if the module is public, or instantiates other classes.
This results in un-instantiated classes that donot correspond to the module hierarchy.
This change ensures that if a class is created for a module, the object is also created from the corresponding instance.
Thus the module hierarchy is also preserved in the
omIR.Downstream tools parsing the IR can assume a single top level class which is required for object model evaluation.