Skip to content

Prefix aware scorer initialization #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mayabar
Copy link
Collaborator

@mayabar mayabar commented May 27, 2025

Use environment variables to define prefix scorer configuration

mayabar added 2 commits May 27, 2025 12:06
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
@mayabar mayabar requested review from elevran and shmuelk May 27, 2025 09:13
- remove PREFIX_SCORER_MAX_BLOCK_CACHE_SIZE, which will be defined internally
- update names of configuration variables in prefix scorer configuration

Signed-off-by: Maya Barnea <mayab@il.ibm.com>
@mayabar mayabar requested review from vMaroon and elevran May 29, 2025 11:01
@mayabar
Copy link
Collaborator Author

mayabar commented May 29, 2025

Ref #55

mayabar and others added 3 commits June 3, 2025 09:06
Add explanation for prefix scorer's environment variable by Maroon

Co-authored-by: Maroon Ayoub <Maroonay@gmail.com>
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
Add cache block size variable description (Maroon)

Co-authored-by: Maroon Ayoub <Maroonay@gmail.com>
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
@mayabar mayabar requested a review from vMaroon June 3, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants