Skip to content

Commit 55c58aa

Browse files
vMaroonelevran
andauthored
Drop llm-d Private Pull Token & Release on Push (#124)
* - removed all private-llm-d repos pull support - removed image-build on push (gha CI) Signed-off-by: Maroon Ayoub <maroon.ayoub@ibm.com> * updated kv-cache-mgr to hash of v0.1.0 Signed-off-by: Etai Lev Ran <elevran@gmail.com> --------- Signed-off-by: Maroon Ayoub <maroon.ayoub@ibm.com> Signed-off-by: Etai Lev Ran <elevran@gmail.com> Co-authored-by: Etai Lev Ran <elevran@gmail.com>
1 parent 4d2f6f6 commit 55c58aa

File tree

9 files changed

+3
-83
lines changed

9 files changed

+3
-83
lines changed

.github/actions/docker-build-and-push/action.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,6 @@ inputs:
1010
github-token:
1111
required: true
1212
description: GitHub token for login
13-
kv-cache-manager-token:
14-
required: true
15-
description: KV Cache Manager llm-d repo token
1613
registry:
1714
required: true
1815
description: Container registry (e.g., ghcr.io/llm-d)
@@ -37,7 +34,6 @@ runs:
3734
run: |
3835
docker buildx build \
3936
--platform linux/amd64 \
40-
--build-arg KV_CACHE_MANAGER_TOKEN=${{ inputs.kv-cache-manager-token }} \
4137
-t ${{ inputs.registry }}/${{ inputs.image-name }}:${{ inputs.tag }} \
4238
--push .
4339
shell: bash

.github/workflows/ci-pr-checks.yaml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,6 @@ jobs:
2525
go-version: "${{ env.GO_VERSION }}"
2626
cache-dependency-path: ./go.sum
2727

28-
- name: Configure Git to use token for private modules
29-
run: |
30-
git config --global url."https://${{ secrets.KV_CACHE_MANAGER_TOKEN }}@github.com/".insteadOf "https://github.com/"
31-
go env -w GOPRIVATE=github.com/llm-d/*
32-
3328
- name: go mod tidy
3429
run: go mod tidy
3530

.github/workflows/ci-push.yaml

Lines changed: 0 additions & 48 deletions
This file was deleted.

.github/workflows/ci-release.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ jobs:
4242
image-name: ${{ steps.version.outputs.project_name }}
4343
registry: ghcr.io/llm-d
4444
github-token: ${{ secrets.GHCR_TOKEN }}
45-
kv-cache-manager-token: ${{ secrets.KV_CACHE_MANAGER_TOKEN }}
4645

4746
- name: Run Trivy scan
4847
uses: ./.github/actions/trivy-scan

.version.json

Lines changed: 0 additions & 6 deletions
This file was deleted.

Dockerfile

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,6 @@ RUN dnf install -y gcc-c++ libstdc++ libstdc++-devel clang && dnf clean all
88

99
WORKDIR /workspace
1010

11-
## llm-d internal repos pull config
12-
ARG KV_CACHE_MANAGER_TOKEN
13-
RUN git config --global url."https://${KV_CACHE_MANAGER_TOKEN}@github.com/".insteadOf "https://github.com/"
14-
ENV GOPRIVATE=github.com/llm-d/*
15-
1611
# Copy the Go Modules manifests
1712
COPY go.mod go.mod
1813
COPY go.sum go.sum

Makefile

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -83,11 +83,6 @@ build: check-go download-tokenizer ##
8383
##@ Container Build/Push
8484

8585
.PHONY: buildah-build
86-
buildah-build: check-builder load-version-json ## Build and push image (multi-arch if supported)
87-
@echo "✅ Using builder: $(BUILDER)"
88-
ifndef KV_CACHE_MANAGER_TOKEN
89-
$(error "KV_CACHE_MANAGER_TOKEN is not set")
90-
endif
9186
@if [ "$(BUILDER)" = "buildah" ]; then \
9287
echo "🔧 Buildah detected: Performing multi-arch build..."; \
9388
FINAL_TAG=$(IMG); \
@@ -96,7 +91,6 @@ endif
9691
echo "📦 Building for architecture: $$arch"; \
9792
buildah build \
9893
--arch=$$arch \
99-
--build-arg KV_CACHE_MANAGER_TOKEN=$(KV_CACHE_MANAGER_TOKEN) \
10094
--os=linux \
10195
--layers -t $(IMG)-$$arch . || exit 1; \
10296
echo "🚀 Pushing image: $(IMG)-$$arch"; \
@@ -118,7 +112,6 @@ endif
118112
docker buildx use image-builder; \
119113
docker buildx build --push \
120114
--platform=$(PLATFORMS) \
121-
--build-arg KV_CACHE_MANAGER_TOKEN=$(KV_CACHE_MANAGER_TOKEN) \
122115
--tag $(IMG) -f Dockerfile.cross . || exit 1; \
123116
docker buildx rm image-builder || true; \
124117
rm Dockerfile.cross; \
@@ -134,14 +127,10 @@ endif
134127
.PHONY: image-build
135128
image-build: check-container-tool load-version-json ## Build Docker image ## Build Docker image using $(CONTAINER_TOOL)
136129
@printf "\033[33;1m==== Building Docker image $(IMG) ====\033[0m\n"
137-
ifndef KV_CACHE_MANAGER_TOKEN
138-
$(error "KV_CACHE_MANAGER_TOKEN is not set")
139-
endif
140130
$(CONTAINER_TOOL) build \
141131
--platform $(TARGETOS)/$(TARGETARCH) \
142132
--build-arg TARGETOS=$(TARGETOS) \
143133
--build-arg TARGETARCH=$(TARGETARCH) \
144-
--build-arg KV_CACHE_MANAGER_TOKEN=$(KV_CACHE_MANAGER_TOKEN) \
145134
-t $(IMG) .
146135

147136
.PHONY: image-push

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ require (
1010
github.com/go-logr/logr v1.4.2
1111
github.com/google/go-cmp v0.7.0
1212
github.com/hashicorp/golang-lru/v2 v2.0.7
13-
github.com/llm-d/llm-d-kv-cache-manager v0.0.0-20250515082302-b9deb04c44c5
13+
github.com/llm-d/llm-d-kv-cache-manager v0.1.0
1414
github.com/prometheus/client_golang v1.22.0
1515
github.com/stretchr/testify v1.10.0
1616
go.uber.org/zap v1.27.0

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,8 @@ github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY=
9898
github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE=
9999
github.com/kylelemons/godebug v1.1.0 h1:RPNrshWIDI6G2gRW9EHilWtl7Z6Sb1BR0xunSBf0SNc=
100100
github.com/kylelemons/godebug v1.1.0/go.mod h1:9/0rRGxNHcop5bhtWyNeEfOS8JIWk580+fNqagV/RAw=
101-
github.com/llm-d/llm-d-kv-cache-manager v0.0.0-20250515082302-b9deb04c44c5 h1:BB02L+NP4zbsfZ23c5gCeKqxNTmArtzHYwiXIOr91mw=
102-
github.com/llm-d/llm-d-kv-cache-manager v0.0.0-20250515082302-b9deb04c44c5/go.mod h1:Hu7RvpUg5sP1xnQFfO2dbt96AjGPWKuUvWBWiHj/FUU=
101+
github.com/llm-d/llm-d-kv-cache-manager v0.1.0 h1:TabMsVni2AqxsfQtcT3jVjSPvExlbTieJejSVNwlkZ0=
102+
github.com/llm-d/llm-d-kv-cache-manager v0.1.0/go.mod h1:Hu7RvpUg5sP1xnQFfO2dbt96AjGPWKuUvWBWiHj/FUU=
103103
github.com/mailru/easyjson v0.7.7 h1:UGYAvKxe3sBsEDzO8ZeWOSlIQfWFlxbzLZe7hwFURr0=
104104
github.com/mailru/easyjson v0.7.7/go.mod h1:xzfreul335JAWq5oZzymOObrkdz5UnU4kGfJJLY9Nlc=
105105
github.com/modern-go/concurrent v0.0.0-20180228061459-e0a39a4cb421/go.mod h1:6dJC0mAP4ikYIbvyc7fijjWJddQyLn8Ig3JB5CqoB9Q=

0 commit comments

Comments
 (0)