Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Always Random Wildcards #2761 #3147

Open
1 task done
DavidDragonsage opened this issue Jun 15, 2024 · 1 comment
Open
1 task done

[Feature Request]: Always Random Wildcards #2761 #3147

DavidDragonsage opened this issue Jun 15, 2024 · 1 comment
Labels
enhancement New feature or request triage This needs an (initial) review

Comments

@DavidDragonsage
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do?

When the "Disable seed increment" option in the Developer Debug Mode Debug Tools section is active it prevents wildcards from being chosen randomly. This feature allows wildcards selections to function properly even when the seed increment is frozen.

Proposed workflow

  1. Open async_worker.py in the script editor of your choice (I use Brackets)
  2. After line 480, insert this new line: wild_seed = (seed + i) % (constants.MAX_SEED + 1) # always increment seed for wildcards
  3. After line 482, insert this new line: wild_seed = task_seed
  4. In Line 484, task_rng = random.Random(task_seed) to task_rng = random.Random(wild_seed)
  5. Test that wildcards are chosen randomly even when the seed is frozen
  6. Test for normal operation of arrays when the seed is frozen
  7. Test for normal operation of Fooocus when the seed is not frozen

Additional information

The introduction of this small enhancement would enrich the Fooocus experience for a very small overhead, and would likely forestall future bewilderment as to why wildcards do not work in certain situations - precisely at the time when one would count on them to work.

@DavidDragonsage DavidDragonsage added enhancement New feature or request triage This needs an (initial) review labels Jun 15, 2024
@DavidDragonsage
Copy link
Contributor Author

DavidDragonsage commented Jun 15, 2024

I have added a PR to my fork. I have forgotten how to add the PR to the others in Main - but maybe that's something you need to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage This needs an (initial) review
Projects
None yet
Development

No branches or pull requests

1 participant