Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider FOLLOW_AREA #120

Closed
Vergenter opened this issue Apr 12, 2024 · 1 comment
Closed

Slider FOLLOW_AREA #120

Vergenter opened this issue Apr 12, 2024 · 1 comment

Comments

@Vergenter
Copy link

In this line, the FOLLOW_AREA of the slider is assumed to be 3. Is there a specific reason for this?

and _within(nearest_pos, datum.position, rad * 3))):

In the osu!lazer repository, it is set to 2.4f:
https://github.com/ppy/osu/blob/3793a552b8756ae19722382879af72156f039cec/osu.Game.Rulesets.Osu/Objects/Drawables/DrawableSliderBall.cs#L21

Other Player Analysis

7 years ago
~2.4x circle radius based on my tests.

Source: Drezi from https://osu.ppy.sh/community/forums/topics/604682?n=4

My In-Game Analysis

Furthest Successful Hit

hit1
hit2
The follow circle expanded on a slider tick, and the score was judged.
Circle size: 72px ± 5px
Distance from slider tick to cursor: 171px ± 2px
171 / 72= 2.375, which is less than 2.4

Nearest miss

miss1
miss2
The follow circle expanded on a slider tick, and the slider tick miss animation started (cross began to fade in).
Circle size: 72px ± 5px
Distance from slider tick to cursor: 175px ± 2px
175 / 72 = 2.43 , which is greater than 2.4

Therefore, the FOLLOW_AREA should be set to 2.4.

@tybug
Copy link
Collaborator

tybug commented Apr 12, 2024

Thanks, I think you're right. Replay calculation has never been perfect in slider and this is probably one of several reasons why. I've fixed this in 3b6659c.

@tybug tybug closed this as completed Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants