Fix SIP trunk host name in tests and update attribute comments

Author: serhiynovos

livekit/attrs.go

@@ -12,7 +12,9 @@ const (
 	AttrSIPDispatchRuleID = AttrSIPPrefix + "ruleID"
 	// AttrSIPTrunkNumber attribute contains number associate with LiveKit SIP Trunk.
 	// This attribute will be omitted if HidePhoneNumber is set.
-	AttrSIPTrunkNumber   = AttrSIPPrefix + "trunkPhoneNumber"
+	AttrSIPTrunkNumber = AttrSIPPrefix + "trunkPhoneNumber"
+	// AttrSIPTrunkHostName attribute contains host name associate with LiveKit SIP Trunk.
+	// This attribute will be omitted if HidePhoneNumber is set.
 	AttrSIPTrunkHostName = AttrSIPPrefix + "trunkHostName"
 	// AttrSIPPhoneNumber attribute contains number external to LiveKit SIP (caller for inbound and called number for outbound).
 	// This attribute will be omitted if HidePhoneNumber is set.

rpc/sip_test.go

@@ -61,7 +61,7 @@ func TestNewCreateSIPParticipantRequest(t *testing.T) {
 			livekit.AttrSIPCallID:        "call-id",
 			livekit.AttrSIPTrunkID:       "trunk",
 			livekit.AttrSIPTrunkNumber:   "+1111",
-			livekit.AttrSIPTrunkHostName: "sip2.example.com",
+			livekit.AttrSIPTrunkHostName: "xyz.sip.livekit.cloud",
 			livekit.AttrSIPPhoneNumber:   "+3333",
 			livekit.AttrSIPHostName:      "sip.example.com",
 		},

sip/sip_test.go

@@ -649,11 +649,14 @@ func TestEvaluateDispatchRule(t *testing.T) {
 		CallingNumber: "+11112222",
 		CallingHost:   "sip.example.com",
 		CalledNumber:  "+3333",
+		CalledHost:    "sip2.example.com",
 		ExtraAttributes: map[string]string{
 			"prov-attr": "1",
 		},
 	}
-	tr := &livekit.SIPInboundTrunkInfo{SipTrunkId: "trunk"}
+	tr := &livekit.SIPInboundTrunkInfo{
+		SipTrunkId: "trunk",
+	}
 	res, err := EvaluateDispatchRule("p_123", tr, d, r)
 	require.NoError(t, err)
 	require.Equal(t, &rpc.EvaluateSIPDispatchRulesResponse{