Batch 2 Bugfix: IRemoteTrack.SetEnabled: dispatch EnableRemoteTrackRequest over FFI#250
Merged
Merged
Conversation
EnableRemoteTrackRequest was missing from FfiRequestExtensions.Inject's type switch, so every call to IRemoteTrack.SetEnabled threw "Unknown request type: LiveKit.Proto.EnableRemoteTrackRequest" and never reached the native layer. The proto field exists on FfiRequest, just nothing was injecting into it. Adds the one missing case alongside LocalTrackMuteRequest and includes a PlayMode regression test using a new test-only SineWaveAudioSource (which pushes 20ms PCM frames via a timer, avoiding Unity's audio subsystem so it runs cleanly in batch-mode CI). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
MaxHeimbrock
changed the title
ladvoc
reviewed
Apr 22, 2026
| case LocalTrackMuteRequest localTrackMuteRequest: | ||
| ffiRequest.LocalTrackMute = localTrackMuteRequest; | ||
| break; | ||
| case EnableRemoteTrackRequest enableRemoteTrackRequest: |
Contributor
There was a problem hiding this comment.
comment (non-blocking): From our sync, it might be worth later revisiting how the FFI client is implemented to reduce the possibility for this kind of bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`IRemoteTrack.SetEnabled` was completely non-functional:
```
System.Exception: Unknown request type: LiveKit.Proto.EnableRemoteTrackRequest
at LiveKit.Internal.FFIClients.FfiRequestExtensions.Inject[T] (...) in FfiRequestExtensions.cs:237
at LiveKit.Internal.FFIClients.Requests.FfiRequestWrap`1[T].Send () (...) in FfiRequestWrap.cs:59
at LiveKit.IRemoteTrack.SetEnabled (System.Boolean enabled) (...) in Track.cs:59
```
The proto field `EnableRemoteTrack` exists on `FfiRequest` but `FfiRequestExtensions.Inject`'s type switch had no case for `EnableRemoteTrackRequest`, so it fell through to `default` and threw. Adds the one missing case (matches the pattern used for all other request types).
Regression test
`Tests/PlayMode/RemoteTrackEnabledRegressionTests.cs` — publishes an audio track from a second room, waits for `TrackSubscribed` on the subscriber, and calls `SetEnabled(false)` / `SetEnabled(true)`. Before the fix this test throws; after, it round-trips through FFI cleanly.
To make the test runnable in batch-mode CI (no real microphone), also introduces `Tests/PlayMode/Utils/SineWaveAudioSource.cs` — an `RtcAudioSource` subclass that pushes 20ms 48kHz PCM frames from a `System.Threading.Timer`, avoiding Unity's audio subsystem. Same utility is also part of an in-flight coverage expansion branch (`max/more-tests/batch-2`); merging either first is fine, content is identical.
Test plan
🤖 Generated with Claude Code