Measure state sync congestion #661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it seems like you haven't added any nanpa changeset files to this PR. if this pull request includes changes to code, make sure to add a changeset, by writing a file to refer to the manpage for more information. |
|
On iOS, it's "slower", shows some more anomalies, like:
|
|
Eventual "fixes" should come in separate PRs 😢 |
pblazej
commented
Apr 7, 2025
| public final class StateSync<State>: @unchecked Sendable, Loggable { | ||
| // MARK: - Logging | ||
|
|
||
| #if LK_SIGNPOSTS |
There was a problem hiding this comment.
If that's too awkward to read, we can use the .disabled pattern as suggested here https://developer.apple.com/videos/play/wwdc2018/405/ + launch args.
But let's be careful with video critical path here...
|
This is great 🙏 |
hiroshihorie
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.signpostcapabilitiesLK_SIGNPOSTSflag that you need to.definein your SPM vs redirecting logs to/dev/null(OSLog.disabled) - to avoid unexpected behavior/perf penaltysubscript()as we cannot alter the signature here