Swift 6: Room and Track state #652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pblazej
commented
Mar 31, 2025
| @@ -18,7 +18,7 @@ | |||
|
|
|||
| import Foundation | |||
|
|
|||
| enum BroadcastBundleInfo { | |||
| actor BroadcastBundleInfo { | |||
There was a problem hiding this comment.
This is also mostly for the static state (including "mutable" property wrappers below).
ladvoc
approved these changes
Mar 31, 2025
There was a problem hiding this comment.
This is a great PR, there are just two warnings remaining:
- SampleBufferVideoRenderer.swift:L96: “capture of 'sampleBuffer' with non-sendable type 'CMSampleBuffer' in a
@Sendableclosure” - ARCameraCaptureOptions:L27: “non-final class 'ARCameraCaptureOptions' cannot conform to 'Sendable'; use '@unchecked Sendable”
hiroshihorie
approved these changes
Apr 1, 2025
|
There's some stubborn Vision Pro sim: Does not seem related to the PR itself, I'll merge anyway - keeping an eye on that 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last 🎉 portion of Swift 6 warnings, mostly around
State.The algorithm is still pretty simple:
final (internal)/immutable → make itSendable@unchecked SendableUnit tests are mostly
@uncheckedbecause of inheritance, IMO gradually moving to Swift Testing is more important.Fortunately, for most generic/async stuff
T: Sendableis just works (tm), just needs proper annotations.