Skip to content

Remove unnecessary logs from streams #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 21, 2025
Merged

Remove unnecessary logs from streams #641

merged 5 commits into from
Mar 21, 2025

Conversation

pblazej
Copy link
Contributor

@pblazej pblazej commented Mar 21, 2025

In some cases these were the only form of error propagation (although not public), so we need to be careful with that 👍

Copy link

ilo-nanpa bot commented Mar 21, 2025

it seems like you haven't added any nanpa changeset files to this PR.

if this pull request includes changes to code, make sure to add a changeset, by writing a file to .nanpa/<unique-name>.kdl:

minor type="added" "Introduce frobnication algorithm"

refer to the manpage for more information.

@pblazej pblazej requested a review from ladvoc March 21, 2025 12:02
Copy link
Contributor

@ladvoc ladvoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@ladvoc ladvoc merged commit ef1e63c into main Mar 21, 2025
16 of 20 checks passed
@ladvoc ladvoc deleted the blaze/stream-logs branch March 21, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants