Skip to content

Fix audio engine node detach crash #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2025

Conversation

hiroshihorie
Copy link
Member

@hiroshihorie hiroshihorie commented Mar 11, 2025

Patch: webrtc-sdk/webrtc@9dbf95c

Extra safety for node cleanup

Copy link

ilo-nanpa bot commented Mar 11, 2025

it seems like you haven't added any nanpa changeset files to this PR.

if this pull request includes changes to code, make sure to add a changeset, by writing a file to .nanpa/<unique-name>.kdl:

minor type="added" "Introduce frobnication algorithm"

refer to the manpage for more information.

@hiroshihorie hiroshihorie changed the title Fix audio engine node disconnect crash Fix audio engine node detach crash Mar 11, 2025
@hiroshihorie hiroshihorie requested a review from ladvoc March 11, 2025 16:46
Copy link
Contributor

@ladvoc ladvoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@hiroshihorie hiroshihorie merged commit a5be87b into main Mar 11, 2025
14 of 19 checks passed
@hiroshihorie hiroshihorie deleted the hiroshi/audioengine-safe-node-detach branch March 11, 2025 17:06
ladvoc added a commit that referenced this pull request Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants