iOS screen share audio #576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename `SocketConnectionFrameReader` to `SocketConnectionSampleReader`. - Utilize the new `HTTPMessageReader` and `BroadcastSampleDecoder` types. - Replaces the functionality of the existing `Message` class. - `didCapture` now emits a `BroadcastSample`. - General refactoring for enhanced readability.
- Uses the Network framework - Enables bi-directional communication and dynamic message headers
- Create `BroadcastUploader` and `BroadcastReceiver` utilizing `IPCChannel` - Separates concerns of socket communication, message format, and sample encoding/decoding - Integrate into existing code - Remove old components
Ensure proper handling of channel closure initiated either by the capture ending or the broadcast ending.
- Fix socket tests for iOS by using relative paths
hiroshihorie
added a commit
that referenced
this pull request
Feb 13, 2025
- Add version and platform compatibility badges from [Swift Package Index](https://swiftpackageindex.com/) to README - Automatically updated on each release - Add [nanpa](https://github.com/nbsp/nanpa) configuration - Custom script bumps version across repo (currently Podspec, README, and LiveKitSDK class) - GitHub publish workflow (based on workflow from livekit/rust-sdks) - Create workflow to push new releases to Cocopods when a release is published on GitHub I have also added changeset files to my currently open PRs (#565, #576, and #573) that can be used to test this configuration. --------- Co-authored-by: Hiroshi Horie <548776+hiroshihorie@users.noreply.github.com>
hiroshihorie
added a commit
to ladvoc/client-sdk-swift
that referenced
this pull request
Feb 13, 2025
commit aa0a21d Author: Jacob Gelman <3182119+ladvoc@users.noreply.github.com> Date: Thu Feb 13 06:28:21 2025 -0800 Simplify broadcast extension setup with standard format for identifiers (livekit#573) When configuring a broadcast extension, manually setting the info keys `RTCAppGroupIdentifier` and `RTCScreenSharingExtension` is no longer required when using the standard format. The standard format is as follows: - App group: `group.<main-app-bundle-id>` - Broadcast extension: `<main-app-bundle-id>.broadcast` --------- Co-authored-by: Hiroshi Horie <548776+hiroshihorie@users.noreply.github.com> commit c3ee701 Author: Jacob Gelman <3182119+ladvoc@users.noreply.github.com> Date: Thu Feb 13 06:05:00 2025 -0800 Deprecate public broadcast picker extension (livekit#586) Public show method defined as an extension to `RPSystemBroadcastPickerView` has been deprecated in favor of `BroadcastManager.shared.requestActivation()`. --------- Co-authored-by: Hiroshi Horie <548776+hiroshihorie@users.noreply.github.com> commit 0da6660 Author: Jacob Gelman <3182119+ladvoc@users.noreply.github.com> Date: Thu Feb 13 05:55:25 2025 -0800 Release automation (livekit#579) - Add version and platform compatibility badges from [Swift Package Index](https://swiftpackageindex.com/) to README - Automatically updated on each release - Add [nanpa](https://github.com/nbsp/nanpa) configuration - Custom script bumps version across repo (currently Podspec, README, and LiveKitSDK class) - GitHub publish workflow (based on workflow from livekit/rust-sdks) - Create workflow to push new releases to Cocopods when a release is published on GitHub I have also added changeset files to my currently open PRs (livekit#565, livekit#576, and livekit#573) that can be used to test this configuration. --------- Co-authored-by: Hiroshi Horie <548776+hiroshihorie@users.noreply.github.com> commit 5b031c8 Author: Hiroshi Horie <548776+hiroshihorie@users.noreply.github.com> Date: Thu Feb 13 22:36:35 2025 +0900 Update Podspec (livekit#587) Fixes: livekit#566 commit 485e76d Author: Hiroshi Horie <548776+hiroshihorie@users.noreply.github.com> Date: Wed Feb 12 14:36:48 2025 +0900 macOS screen share audio (livekit#561)
hiroshihorie
added a commit
that referenced
this pull request
Feb 14, 2025
This PR revamps inter-process communication between the main app and the broadcast extension, replacing deprecated Core Foundation APIs. Additionally, it enhances testability, enables bi-directional communication, and introduces a more flexible message structure. Summary of new types: - `IPCChannel`: An abstraction for inter-process communication, built on top of the [Network](https://developer.apple.com/documentation/network) framework. Allows asynchronous sending and receiving of messages consisting of a dynamic header (any type conforming to `Codable`) and a data payload. - `BroadcastImageCodec`: Encapsulates functionality for encoding/decoding image samples for transport. For now, this uses the same method of JPEG encoding/decoding as the current implementation. - `BroadcastUploader`: Sends samples from ReplayKit to the main app, built on top of `IPCChannel`. - `BroadcastReceiver`: Receives samples from the broadcast extension, built on top of `IPCChannel`. This PR sets the groundwork for adding support for audio samples, but I decided to submit that in a separate PR (#576) as this is a large change (though not breaking). --------- Co-authored-by: Hiroshi Horie <548776+hiroshihorie@users.noreply.github.com>
|
@ladvoc I think I removed |
…at' into broadcast-audio
…at' into broadcast-audio
hiroshihorie
approved these changes
Feb 21, 2025
AudioConverter.swift was moved into subdirectory
|
@ladvoc Can you fix the |
Use fully qualified type name `Swift.Equatable`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for capturing application audio during screen share when using a broadcast extension.
Note: PR #598 should be merged first.