Skip to content

Commit 8629971

Browse files
fix the RPC tests (#95)
1 parent 838962c commit 8629971

2 files changed

Lines changed: 26 additions & 5 deletions

File tree

src/tests/integration/test_media_multistream.cpp

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -231,10 +231,16 @@ void MediaMultiStreamIntegrationTest::runPublishTwoVideoAndTwoAudioTracks(
231231
}
232232

233233
for (const auto &track : video_tracks) {
234-
sender_room->localParticipant()->unpublishTrack(track->sid());
234+
if (track->publication()) {
235+
sender_room->localParticipant()->unpublishTrack(
236+
track->publication()->sid());
237+
}
235238
}
236239
for (const auto &track : audio_tracks) {
237-
sender_room->localParticipant()->unpublishTrack(track->sid());
240+
if (track->publication()) {
241+
sender_room->localParticipant()->unpublishTrack(
242+
track->publication()->sid());
243+
}
238244
}
239245
}
240246

src/tests/stress/test_latency_measurement.cpp

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -294,8 +294,19 @@ TEST_F(LatencyMeasurementTest, ConnectionTime) {
294294
double latency_ms =
295295
std::chrono::duration<double, std::milli>(end - start).count();
296296
stats.addMeasurement(latency_ms);
297+
298+
// Get room and participant session IDs for debugging
299+
auto room_info = room->room_info();
300+
std::string room_sid =
301+
room_info.sid.has_value() ? room_info.sid.value() : "unknown";
302+
std::string participant_sid = room->localParticipant()
303+
? room->localParticipant()->sid()
304+
: "unknown";
305+
297306
std::cout << " Iteration " << (i + 1) << ": " << std::fixed
298-
<< std::setprecision(2) << latency_ms << " ms" << std::endl;
307+
<< std::setprecision(2) << latency_ms << " ms"
308+
<< " | participant_sid=" << participant_sid
309+
<< " | room_sid=" << room_sid << std::endl;
299310

300311
} else {
301312
std::cout << " Iteration " << (i + 1) << ": FAILED to connect"
@@ -841,8 +852,12 @@ TEST_F(LatencyMeasurementTest, FullDeplexAudioLatency) {
841852
std::cout << "Response timeouts: " << timeouts << std::endl;
842853
}
843854

844-
room_a->localParticipant()->unpublishTrack(track_a->sid());
845-
room_b->localParticipant()->unpublishTrack(track_b->sid());
855+
if (track_a->publication()) {
856+
room_a->localParticipant()->unpublishTrack(track_a->publication()->sid());
857+
}
858+
if (track_b->publication()) {
859+
room_b->localParticipant()->unpublishTrack(track_b->publication()->sid());
860+
}
846861

847862
EXPECT_GT(round_trip_stats.count(), 0)
848863
<< "At least one round-trip latency measurement should be recorded";

0 commit comments

Comments
 (0)