This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[Bug 19347] Allow setting the 'style' of the stack from the PI #1631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR fixes the problem, but I am not sure if setting the |
|
@livecodepanos what about checking if the stack is currently open before setting the style to modal and throwing up a warning dialog first if it is? We have the same issue from the contextual menu I think so perhaps this can be handled centrally. |
livecodeali
reviewed
Sep 8, 2017
| @@ -7,7 +7,7 @@ name | |||
| title | |||
| mainStack | |||
| decorations | |||
| style Toplevel,Modeless,Modal,Palette | |||
| style Toplevel Toplevel,Modeless,Modal,Palette | |||
There was a problem hiding this comment.
If you do style::revIDESetModeOfStack here, it will use the revIDESetModeOfStack as the property setter, so you can remove your change to revIDEPropertySet (in theory)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.