Skip to content

Commit 4b8cbeb

Browse files
ilonatommyliveans
authored andcommitted
Explanation for UseSystemResourceKeys=false (dotnet#94054)
1 parent 7a4aa94 commit 4b8cbeb

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/mono/wasm/Wasm.Build.Tests/IcuTestsBase.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@ protected void TestIcuShards(BuildArgs buildArgs, string shardName, string teste
108108
bool dotnetWasmFromRuntimePack = !(buildArgs.AOT || buildArgs.Config == "Release");
109109

110110
buildArgs = buildArgs with { ProjectName = projectName };
111+
// by default, we remove resource strings from an app. ICU tests are checking exception messages contents -> resource string keys are not enough
111112
string extraProperties = $"<WasmIcuDataFileName>{shardName}</WasmIcuDataFileName><UseSystemResourceKeys>false</UseSystemResourceKeys>";
112113
if (onlyPredefinedCultures)
113114
extraProperties = $"{extraProperties}<PredefinedCulturesOnly>true</PredefinedCulturesOnly>";
@@ -125,4 +126,4 @@ protected void TestIcuShards(BuildArgs buildArgs, string shardName, string teste
125126

126127
string runOutput = RunAndTestWasmApp(buildArgs, buildDir: _projectDir, expectedExitCode: 42, host: host, id: id);
127128
}
128-
}
129+
}

0 commit comments

Comments
 (0)