Protect (LFS_ASSERT) file operations against using not opened or closed files. #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh hey, thanks for this! This looks perfect, I will merge it next chance I get 👍 Just to let you know, if you force-push to the same branch, GitHub will automatically update any PRs using that branch. |
geky
approved these changes
Jul 21, 2019
|
Just an FYI I also create a PR to change the rdonly/wronly asserts, these should be able to go in together. I created a separate PR so others would be able to see that this is changing if they are watching the repo. |
|
Just an FYI, I had to remove the assert in We unfortunately can't assume the initial value of the lfs_file_t struct in lfs_file_opencfg. But at least this is still useful for protecting against operations on closed files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not allow some file operations to (re)use lfs_file_t stucture when file is already opened (prohibit open) or not opened/closed (prohibit all operations but open).
It is achieved by adding new internal file flag. This flag is set in lfs_file_open and it is reset in lfs_file_close. It is also tested in each (file related) API call as an ASSERTprecondition.
This is second attempt to add this functionality after discussion in pull request #213.