Skip to content

Conversation

@Anton-Fat
Copy link

No description provided.

@geky-bot
Copy link
Collaborator

geky-bot commented Aug 8, 2025

Tests passed ✓, Code: 17112 B (+0.0%), Stack: 1448 B (+0.0%), Structs: 812 B (+0.0%)
Code Stack Structs Coverage
Default 17112 B (+0.0%) 1448 B (+0.0%) 812 B (+0.0%) Lines 2435/2595 lines (-0.0%)
Readonly 6230 B (+0.0%) 448 B (+0.0%) 812 B (+0.0%) Branches 1283/1616 branches (+0.0%)
Threadsafe 17964 B (+0.0%) 1448 B (+0.0%) 820 B (+0.0%) Benchmarks
Multiversion 17184 B (+0.0%) 1448 B (+0.0%) 816 B (+0.0%) Readed 29369693876 B (+0.0%)
Migrate 18776 B (+0.0%) 1752 B (+0.0%) 816 B (+0.0%) Proged 1482874766 B (+0.0%)
Error-asserts 17924 B (+0.0%) 1440 B (+0.0%) 812 B (+0.0%) Erased 1568888832 B (+0.0%)

@BenBE
Copy link

BenBE commented Aug 8, 2025

Не могли бы вы написать комментарии в коде на английском? Так они будут полезны гораздо более широкой аудитории.

Copy link

@bmcdonnell-fb bmcdonnell-fb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR relates to #857. We had some discussion there about whether or not it's a desirable to include this in the repo.

I did just a quick skim review here.

Also I agree with @BenBE that (if this gets merged) it's preferable to have comments in English.

Comment on lines +39 to +45
# todo: add module CMSIS

# Перечисление зависимостей
# list(APPEND ${PROJECT_NAME}_DEPENDENCIES
# CMSIS
# typedef
# )

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these here? Seems undesirable.

@geky
Copy link
Member

geky commented Aug 11, 2025

I think the best path for cmake support at the moment would be if someone volunteered to host/maintain a CMakeLists.txt outside of this org.

We could add a link to it in the README.md (and eventually website) to direct potential users, like we have with littlefs-python, littlefs2-rust, etc.

If such a CMakeLists.txt matures, and there's interest, I can eventually bring it into this org as an "official(?)" repo and volunteer to maintain it. But 1. I don't think it's high-priority, and 2. I'm not yet convinced there's a single CMakeLists.txt that covers enough use cases to be worth the maintenance headache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants