update date filter to pass integers to graphql #5087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 8, 2025 09:01
Signed-off-by: Priya Bibra <priya.bibra@airbnb.com>
Signed-off-by: Priya Bibra <priya.bibra@airbnb.com>
pbibra
force-pushed
the
pbibra-fix-date-filters
branch
from
ad57b4c to
abe50a5
Compare
S-ayanide
approved these changes
Apr 9, 2025
added 2 commits
April 9, 2025 09:29
Signed-off-by: Priya Bibra <priya.bibra@airbnb.com>
Calvinaud
pushed a commit
to Calvinaud/litmus
that referenced
this pull request
May 20, 2025
* update date filter to pass ints to graphql Signed-off-by: Priya Bibra <priya.bibra@airbnb.com> * revert go mod Signed-off-by: Priya Bibra <priya.bibra@airbnb.com> * sign Signed-off-by: Priya Bibra <priya.bibra@airbnb.com> * gofmt Signed-off-by: Priya Bibra <priya.bibra@airbnb.com> * revert go ver Signed-off-by: Priya Bibra <priya.bibra@airbnb.com> --------- Signed-off-by: Priya Bibra <priya.bibra@airbnb.com> Co-authored-by: Priya Bibra <priya.bibra@airbnb.com> Signed-off-by: Calvin Audier <calvin.audier@amadeus.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Date filters when listing experiments or experiment runs do not currently work because mongodb stores
updated_atas an integer and we pass in strings. This PR updates to convert the date range from a string to an int. Alternatively, the type of the date filter could have been changed, but that would break existing workflows so opted not to do it that way.Issue: #5078
Slack thread: https://kubernetes.slack.com/archives/CNXNB0ZTN/p1742510947495359
Types of changes
What types of changes does your code introduce to Litmus? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer:
Verified via local instal that the UI now filters experiments by date correctly.
No experiment on Apr 7th, 2025
Single experiment on Apr 8th, 2025
