-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #4773: Added '#' as a valid Password Character #4833
fixes #4773: Added '#' as a valid Password Character #4833
Conversation
Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
It would be great if you add unit tests to auth-server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I’m currently occupied with another task, but I'll try to add the unit tests for the auth-server when I get some time |
Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com> Co-authored-by: Namkyu Park <53862866+namkyu1999@users.noreply.github.com> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com> Co-authored-by: Namkyu Park <53862866+namkyu1999@users.noreply.github.com> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com> Co-authored-by: Namkyu Park <53862866+namkyu1999@users.noreply.github.com> Signed-off-by: sagnik3788 <116512372+sagnik3788@users.noreply.github.com>
Proposed changes
added '#' as a valid password character
fixes #4773
Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: