Skip to content

feat : Group chaos infra in infrastructure selection modal #4779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Saranya-jena merged 15 commits into from
Sep 6, 2024
Merged

feat : Group chaos infra in infrastructure selection modal #4779

Saranya-jena merged 15 commits into from
Sep 6, 2024

Conversation

@JanhaviAlekar
Copy link
Contributor

@JanhaviAlekar JanhaviAlekar commented Jul 19, 2024 •
edited
Loading

Proposed changes

Screencast.from.05-08-24.06.22.12.PM.IST.webm

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

JanhaviAlekar and others added 4 commits July 19, 2024 13:45
@JanhaviAlekar
Adding environment filter in Infrastructure selection modal
2ba04ac 
Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>
@JanhaviAlekar
setting initialAllInfrastructureLength as 0 initially
a35b859 
Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>
@JanhaviAlekar
making InitialAllInfrastructureLength consistent
421e8e5 
Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>
@JanhaviAlekar
Merge branch 'master' into group-chaos-infra-in-infra-selection-modal
0f50fa9
JanhaviAlekar and others added 3 commits August 5, 2024 20:29
@JanhaviAlekar
added preSelectedEnvironmentID
a4c626f 
Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>
@JanhaviAlekar
Merge branch 'master' into group-chaos-infra-in-infra-selection-modal
9629b46
@JanhaviAlekar
Minor changes in code
a46952e 
Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>
SahilKr24
SahilKr24 requested changes Aug 6, 2024
View reviewed changes
Copy link
Member

@SahilKr24 SahilKr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good first attempt, but need a bit more of work

@JanhaviAlekar
Refactored code
e0ab1bd 
Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>
@JanhaviAlekar JanhaviAlekar requested a review from SahilKr24 August 9, 2024 13:40
SahilKr24
SahilKr24 reviewed Aug 21, 2024
View reviewed changes
.../KubernetesChaosInfrastructureReferenceField/KubernetesChaosInfrastructureReferenceField.tsx Outdated
gotoPage={setPage}
showPagination={true}
pageSizeOptions={[5, 10, 15]}
onPageSizeChange={event => setLimit(parseInt(event.toString()))}
Copy link
Member

@SahilKr24 SahilKr24 Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onPageSizeChange={setLimit}

SahilKr24
SahilKr24 approved these changes Aug 21, 2024
View reviewed changes
...center/web/src/views/ChaosInfrastructureReferenceField/ChaosInfrastructureReferenceField.tsx Outdated
const { getString } = useStrings();

const listingEnvironment = ({ env }: { env: Environment }): JSX.Element => {
const EnvListItem = ({ EnvDetail }: { EnvDetail: EnvironmentDetail }): JSX.Element => {
Copy link
Member

@SahilKr24 SahilKr24 Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnvDetail in camelCase

...center/web/src/views/ChaosInfrastructureReferenceField/ChaosInfrastructureReferenceField.tsx Outdated
rightIcon="chevron-down"
iconProps={{ size: 14 }}
onClick={() => setOpen(true)}
onClick={() => open()}
Copy link
Member

@SahilKr24 SahilKr24 Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onClick={open}

...center/web/src/views/ChaosInfrastructureReferenceField/ChaosInfrastructureReferenceField.tsx Outdated
placeholder={getString('search')}
onChange={e => setSearchInfrastructure(e)}
/>
{isOpen && (
Copy link
Member

@SahilKr24 SahilKr24 Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might not me required, please check and remove

...center/web/src/views/ChaosInfrastructureReferenceField/ChaosInfrastructureReferenceField.tsx Outdated
history.push(paths.toEnvironments());
}}
/>
<EnvListItem EnvDetail={{ envName: 'all', envID: 'all', totalInfra: allInfrastructureLength }} />
Copy link
Member

@SahilKr24 SahilKr24 Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings

@JanhaviAlekar
Minor improvements
1bdc7e4 
Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>
@Saranya-jena Saranya-jena requested a review from amityt August 23, 2024 06:40
@Saranya-jena Saranya-jena merged commit 1a03758 into litmuschaos:master Sep 6, 2024
andoriyaprashant pushed a commit to andoriyaprashant/litmus that referenced this pull request Sep 7, 2024
@JanhaviAlekar @SahilKr24
@Saranya-jena @andoriyaprashant
feat : Group chaos infra in infrastructure selection modal (litmuscha…
4fd5613 
…os#4779)

* Adding environment filter in Infrastructure selection modal

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

* setting initialAllInfrastructureLength as 0 initially

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

* making InitialAllInfrastructureLength consistent

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

* Scroll env list and Pagination(infra)

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

* added preSelectedEnvironmentID

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

* Minor changes in code

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

* Refactored code

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

* Changing height of infralist section

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

* Minor improvements

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

---------

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>
Co-authored-by: Sahil <sahil.kumar@harness.io>
Co-authored-by: Saranya Jena <saranya.jena@harness.io>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
andoriyaprashant pushed a commit to andoriyaprashant/litmus that referenced this pull request Sep 7, 2024
@JanhaviAlekar @SahilKr24
@Saranya-jena @andoriyaprashant
feat : Group chaos infra in infrastructure selection modal (litmuscha…
f41c158 
…os#4779)

* Adding environment filter in Infrastructure selection modal

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

* setting initialAllInfrastructureLength as 0 initially

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

* making InitialAllInfrastructureLength consistent

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

* Scroll env list and Pagination(infra)

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

* added preSelectedEnvironmentID

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

* Minor changes in code

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

* Refactored code

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

* Changing height of infralist section

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

* Minor improvements

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

---------

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>
Co-authored-by: Sahil <sahil.kumar@harness.io>
Co-authored-by: Saranya Jena <saranya.jena@harness.io>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
sagnik3788 pushed a commit to sagnik3788/litmus that referenced this pull request Oct 5, 2024
@JanhaviAlekar @SahilKr24
@Saranya-jena @sagnik3788
feat : Group chaos infra in infrastructure selection modal (litmuscha…
65ac785 
…os#4779)

* Adding environment filter in Infrastructure selection modal

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

* setting initialAllInfrastructureLength as 0 initially

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

* making InitialAllInfrastructureLength consistent

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

* Scroll env list and Pagination(infra)

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

* added preSelectedEnvironmentID

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

* Minor changes in code

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

* Refactored code

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

* Changing height of infralist section

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

* Minor improvements

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>

---------

Signed-off-by: JanhaviAlekar <janhavialekar@gmail.com>
Co-authored-by: Sahil <sahil.kumar@harness.io>
Co-authored-by: Saranya Jena <saranya.jena@harness.io>
Signed-off-by: sagnik3788 <116512372+sagnik3788@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Saranya-jena Saranya-jena Saranya-jena approved these changes

@SahilKr24 SahilKr24 SahilKr24 approved these changes

@arkajyotiMukherjee arkajyotiMukherjee Awaiting requested review from arkajyotiMukherjee

@amityt amityt Awaiting requested review from amityt

Assignees

@JanhaviAlekar JanhaviAlekar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JanhaviAlekar @Saranya-jena @SahilKr24