Skip to content

Conversation

@dusdjhyeon
Copy link
Contributor

Proposed changes

We migrated the base image of the dockerfile in choascenter to UBI. Changing the exit-code to 1 only for the changed image to check if there are any vulnerabilities.

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

Signed-off-by: dusdjhyeon <dusdj0813@gmail.com>
Signed-off-by: dusdjhyeon <dusdj0813@gmail.com>
@Jonsy13
Copy link
Contributor

Jonsy13 commented Jul 17, 2024

Nice this is great!! 🚀

@Jonsy13 Jonsy13 merged commit 67a1985 into litmuschaos:master Jul 17, 2024
andoriyaprashant pushed a commit to andoriyaprashant/litmus that referenced this pull request Sep 7, 2024
* feat: change exit-code

Signed-off-by: dusdjhyeon <dusdj0813@gmail.com>

* chore: Just for build triggers

Signed-off-by: dusdjhyeon <dusdj0813@gmail.com>

---------

Signed-off-by: dusdjhyeon <dusdj0813@gmail.com>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
andoriyaprashant pushed a commit to andoriyaprashant/litmus that referenced this pull request Sep 7, 2024
* feat: change exit-code

Signed-off-by: dusdjhyeon <dusdj0813@gmail.com>

* chore: Just for build triggers

Signed-off-by: dusdjhyeon <dusdj0813@gmail.com>

---------

Signed-off-by: dusdjhyeon <dusdj0813@gmail.com>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
sagnik3788 pushed a commit to sagnik3788/litmus that referenced this pull request Oct 5, 2024
* feat: change exit-code

Signed-off-by: dusdjhyeon <dusdj0813@gmail.com>

* chore: Just for build triggers

Signed-off-by: dusdjhyeon <dusdj0813@gmail.com>

---------

Signed-off-by: dusdjhyeon <dusdj0813@gmail.com>
Signed-off-by: sagnik3788 <116512372+sagnik3788@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants