Fixing race condition and improving monitor stability#1451
Closed
neilSchroeder wants to merge 2 commits intolithops-cloud:masterfrom
Closed
Fixing race condition and improving monitor stability#1451neilSchroeder wants to merge 2 commits intolithops-cloud:masterfrom
neilSchroeder wants to merge 2 commits intolithops-cloud:masterfrom
Conversation
Contributor
|
@neilSchroeder can you submit a PR without linting changes (or put those in a separate commit) - so it's easier to review please. |
Contributor
Author
|
Closing to open new PR without linting changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Developer's Certificate of Origin 1.1
What
An attempt to solve the race condition described in #1449.
Why
Without this the monitor regularly gets disconnected and abandons futures resulting in indefinite polling and interrupted job streams.