Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adjust min/max items to valid lengths for Set[Enum] fields #567

Merged
merged 8 commits into from
Sep 13, 2024
Merged

fix: Adjust min/max items to valid lengths for Set[Enum] fields #567

merged 8 commits into from
Sep 13, 2024

Commits on Jul 19, 2024

  1. fix: Adjust min/max items to valid lengths for Set[Enum] fields 

    For `Set[Enum]` fields with a limited maximum length, adjust `min_items`
and `max_items` to be within the range of valid lengths.
    @adrianeboyd
    adrianeboyd committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    7cd5a7e View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2024

  1. Check for set/unique and add handling for Literal

    @adrianeboyd
    adrianeboyd committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    ba3c6fe View commit details
    Browse the repository at this point in the history

  2. Move tests to collection_length and add tests for Literal and non-lim… 

    …ited List
    @adrianeboyd
    adrianeboyd committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    baed5b4 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2024

  1. Merge branch 'main' into fix-set-enum-length

    @guacs
    guacs committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    cd0e96a View commit details
    Browse the repository at this point in the history

  2. Fix Literal and max_items, parameterize and extend tests 

    - `min_items` should be at most the number of possible values
- `max_items` for `Literal` should be the number of possible values
- `max_items` for both `Enum` and `Literal` shouldn't clobber a provided
  `max_items` that's lower than the number of possible values
- run the sanity check for `min_items <= max_items` before any values
  are modified
    @adrianeboyd
    adrianeboyd committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    ba718c6 View commit details
    Browse the repository at this point in the history

  3. Fix FieldMeta length check

    @adrianeboyd
    adrianeboyd committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    f20f114 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Check length for all collection types

    @adrianeboyd
    adrianeboyd committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    1b390aa View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Merge branch 'main' into fix-set-enum-length

    @guacs
    guacs committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    5802a4c View commit details
    Browse the repository at this point in the history