-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: constrained unions #499
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
4 tasks
guacs
force-pushed
the
constrained-unions
branch
from
March 2, 2024 13:48
7fcab33
to
e41aedc
Compare
Quality Gate failedFailed conditions |
Documentation preview will be available shortly at https://litestar-org.github.io/polyfactory-docs-preview/499 |
I think the sonar code coverage issue can be ignored since the missing coverage is for the 3.8 specific code. |
provinzkraut
approved these changes
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NoneType
. This makes the change the same as that ofFieldMeta.from_type
(as changed in fix: handle unions properly #491).FieldMeta.from-type
by using the actual type that is annotated rather thanAnnotated[type, ...]
FieldMeta.type_args
in fix: handle unions properly #491,Annotated[List[str], MinLen(10)]
now returnsList[str]
whereas before it would have returnedstr
as the child. This results in the children for theFieldMeta
corresponding to the annotationAnnotated[List[str], MinLen(10)]
to beList[str]
instead ofstr
. Unwrapping the annotation to get the actual underlying type fixes this problem since nowFieldMeta.type_args
will returnstr
in this case instead ofList[str]
.Close Issue(s)