Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to send event data to tee #1352

Open
ziming-zung opened this issue Feb 20, 2023 · 3 comments
Open

Try to send event data to tee #1352

ziming-zung opened this issue Feb 20, 2023 · 3 comments
Labels
D1-feature A new feature, a piece of functionality that needs to be developed I2-medium should be completed within 10 working days Stale

Comments

@ziming-zung
Copy link
Contributor

Context

After solving issue #1092, we can know whether extrinsic is executed successfully in the parentchain. But in some corner cases, it is not enough, we still want to get event data in tee, such as in issue #1152, if we can not get the event data, it's hard to know whether each sub-extrinsic is executed successfully(except with batch-all). So I think the best solution is that each extrinsic can get its own event data.

Solution

Maybe we can refer to the implementation of #1092 which means we simply append the event data(bytes) to opaque extrinsic. see

pub fn fill_opaque_extrinsic_with_status(
opaque_extrinsic: OpaqueExtrinsic,
status: bool,
) -> Result<OpaqueExtrinsic, codec::Error> {
let opaque_extrinsic_with_status = OpaqueExtrinsicWithStatus { xt: opaque_extrinsic, status };
OpaqueExtrinsic::from_bytes(opaque_extrinsic_with_status.encode().as_slice())
}

@github-actions
Copy link
Contributor

❗ This issue is stale because it has been open for 60 days with no activity.
Remove Stale label or update it, otherwise this issue will be closed in 7 days.
@litentry/parachain

@github-actions github-actions bot added the Stale label Apr 22, 2023
@Kailai-Wang
Copy link
Collaborator

still relevant, but maybe keep an eye on this: integritee-network/worker#1248

@Kailai-Wang Kailai-Wang added I2-medium should be completed within 10 working days D1-feature A new feature, a piece of functionality that needs to be developed and removed Stale labels Apr 22, 2023
@github-actions
Copy link
Contributor

❗ This issue is stale because it has been open for 60 days with no activity.
Remove Stale label or update it, otherwise this issue will be closed in 7 days.
@litentry/parachain

@github-actions github-actions bot added the Stale label Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D1-feature A new feature, a piece of functionality that needs to be developed I2-medium should be completed within 10 working days Stale
Projects
None yet
Development

No branches or pull requests

3 participants