Use user_uid over user_email ubiquitously
#3386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kziemianek
reviewed
Apr 14, 2025
tee-worker/omni-executor/rpc-server/src/methods/pumpx/export_wallet.rs
Outdated
Show resolved
Hide resolved
silva-fj
reviewed
Apr 14, 2025
There was a problem hiding this comment.
I think we should get the user ID from the BE, for us there is no way to verify it and map it to the user's email. We can keep the email authentication as it is, call the BE to get the user ID for that email and issue the JWTs with the OmniAcccount (sub) derived from that ID
…er-user_email-ubiquitously
kziemianek
reviewed
Apr 14, 2025
| ); | ||
| }; | ||
|
|
||
| if res.user_id != params.user_id { |
There was a problem hiding this comment.
If we query it from backend anyway can we simply not accept it from frontend ?
There was a problem hiding this comment.
I think it gives us extra chance to tell F/E something goes wrong early.
If F/E doesn't pass in user_email - it could still give the wrong/arbitrary user_id. Now at least they need to pass in matching pairs.
kziemianek
approved these changes
Apr 14, 2025
silva-fj
approved these changes
Apr 14, 2025
Kailai-Wang
deleted the
p-1464-use-user_uid-over-user_email-ubiquitously
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As topic - hopefully we get the same mapped omni-account as backend this way so we don't have to move assets.
For some cases where email verification code needs to be validated, a
user_emailis still needed.In
exportWalletandwithdrawit verifies if the user_id and user_email matchIt also provides a helper rpc
pumpx_getOmniAccountfor cross-check