Optimize English g2p function for improved speed and efficiency #124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This merge request optimizes the English
g2p
function to significantly improve its performance, resolving Issue #104. The primary changes include moving global variables to the top-level scope to avoid redundant initialization, simplifying conditions, and streamlining functions.Changes:
ARPA
,_g2p
,eng_dict
, andtokenizer
to the top-level scope to prevent redundant initialization.Performance Impact:
These modifications resulted in a significant speed improvement for the
g2p
functionexample test was conducted as inferencing a sentence 100 times sequentially
before modification
after modification