Update components/rendering guide #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 29, 2021 12:21
|
A live preview of this PR will be available at the URL(s) below. https://pr137-ab07dd5---lit-dev-bvxw3ycs6q-uw.a.run.app/ |
sorvell
requested changes
Feb 24, 2021
There was a problem hiding this comment.
I don't feel like this section is paying for itself. Suggest removing it and just putting links to the other relevant sections in the Overview: Shadow DOM, Lifecycle, and Template overview.
The part about the performant template maybe can be added as a sub-section to lifecycle#render.
packages/lit-dev-content/site/_includes/projects/docs/templates/compose/my-page.ts
Outdated
Show resolved
Hide resolved
| @@ -6,79 +6,66 @@ eleventyNavigation: | |||
| order: 2 | |||
| --- | |||
|
|
|||
| {% todo %} | |||
| A Lit component typically implements its UI by rendering an encapsulated DOM tree. | |||
There was a problem hiding this comment.
This sentence isn't adding much for me. Remove?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds intro, interactive examples.
I am not real happy about the "Designing a performant template" section ... I think the info is good but the example is kind of longwinded. Welcome input on that.
I think Justin was the one who requested adding a "when components render" section, so let me know if this is what you were thinking of. (The info was already kind of there, but previously formed part of the "Designing a performant template" section.)