Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Term.num2str(): Ordinal number of 111 is "111th", but "111st" was returned #221

Closed
lisphilar opened this issue Sep 4, 2020 · 1 comment
Closed

Term.num2str(): Ordinal number of 111 is "111th", but "111st" was returned #221

lisphilar opened this issue Sep 4, 2020 · 1 comment
Labels
bug Something isn't working
Milestone
Release CovsirPhy...

Comments

@lisphilar
Copy link
Owner

Summary

Term.num2str(): Ordinal number of 111 is "111th", but "111st" was returned. This bug will impact on phases names when over 111 change points exists.

Related classes

  • covsirphy.Term

Codes and outputs:

from covsirphy import Term
Term.num2str(111)

This code should return "111th", but "111st" was returned.

Environment

  • CovsirPhy version: 2.8.1
  • Python version; 3.8
  • Installation: pipenv
  • OS: WSL
@lisphilar lisphilar added the bug Something isn't working label Sep 4, 2020
@lisphilar lisphilar mentioned this issue Sep 4, 2020
Merged
@lisphilar
Copy link
Owner Author

WIll be fixed in version 2.8.1-alpha and stable version 2.8.2 or 2.9.0

@lisphilar lisphilar added this to the Release CovsirPhy v2.8.2 milestone Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Release CovsirPhy v2.8.2
Development

No branches or pull requests
1 participant
@lisphilar