ArrayBuffer/WebSocket issue with version 3.2.2 (unexpected base64 conversion!) #447

epeios-q37 · 2024-08-10T08:43:37Z

Hello,

The below file opens a WebSocket on a site (wss://echo.websocket.org) which simply echoes what is send, and sends a text as ArrayBuffer.
When using version 3.2.1, the response is a blob containing the sent text, which is the expected behavior.
When using version 3.2.2 , the response is a text which is the sent text encoded in base64, which is wrong.

Below the steps to reproduce the issue.

Create an HTML file with below content;
open this file in a web browser;
open the JS console (the browser one or the eruda one);
you should see, as expected:

Blob (correct):  This is the text used for testing!

Now:

change in the file at line 5 3.2.1 to 3.2.2 (switching to the latest version);
reload the file in the web browser;
reopen, if needed, the JS console;
you will see:

Text (wrong):  VGhpcyBpcyB0aGUgdGV4dCB1c2VkIGZvciB0ZXN0aW5nIQ==
Base64 decoded above text:  This is the text used for testing!

Maybe the problem only affects ArrayBuffer or only WebSocket, but I couldn't reproduce the problem without involving both (I very rarely use JS)...

The bug_eruda.html file (HTML files can not be joined to issues ):

<!DOCTYPE html>
<html>
  <head>
    <!-- Version 3.2.1 works, version 3.2.2 fails! -->
    <script src="https://cdn.jsdelivr.net/npm/eruda@3.2.1/eruda.min.js"></script>
    <script>
      function test() {
        const text = "This is the text used for testing!"

        const enc = new TextEncoder();
        const ws = new WebSocket("wss://echo.websocket.org");

        function logBlob(blob) {
          const reader = new FileReader()

          function onLoadEnd (e) {
            reader.removeEventListener('loadend', onLoadEnd, false)
            console.log("Blob (correct): ", reader.result);
          }

          reader.addEventListener('loadend', onLoadEnd, false)
          reader.readAsText(blob)
        }

        ws.onmessage = function (event) {
          if ( event.data.type === "")
            logBlob(event.data);
          else if ( !event.data.startsWith("Request")) {  // To skip the first response of 'echo.websocket.org'.
            console.log("Text (wrong): ", event.data);
            console.log("Base64 decoded above text: ", atob(event.data));
           }
        }

        ws.onopen = function () {
          ws.send(enc.encode(text));
        };
      }
    </script>
    </head>
  <body onload="eruda.init();test();">
  </body>
</html>

The text was updated successfully, but these errors were encountered:

surunzi · 2024-08-10T15:13:25Z

v3.2.3 fixes this issue.

epeios-q37 · 2024-08-10T19:33:48Z

Thanks for this quick fix!

surunzi closed this as completed Aug 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ArrayBuffer/WebSocket issue with version 3.2.2 (unexpected base64 conversion!) #447

ArrayBuffer/WebSocket issue with version 3.2.2 (unexpected base64 conversion!) #447

epeios-q37 commented Aug 10, 2024 •

edited

Loading

surunzi commented Aug 10, 2024

epeios-q37 commented Aug 10, 2024

ArrayBuffer/WebSocket issue with version 3.2.2 (unexpected base64 conversion!) #447

ArrayBuffer/WebSocket issue with version 3.2.2 (unexpected base64 conversion!) #447

Comments

epeios-q37 commented Aug 10, 2024 • edited Loading

surunzi commented Aug 10, 2024

epeios-q37 commented Aug 10, 2024

epeios-q37 commented Aug 10, 2024 •

edited

Loading