Prevent bLUSD LP withdrawal MEV sandwiching #1005
Conversation
|
It looks good, although I'm not sure how precise the withdrawal prediction is (particularly those cases where we rely on Have you tried each case (bLUSD, LUSD, both)? |
|
Good suggestion on fixing a min slippage. This should reduce transaction failure. With a slippage of 0.1% I didn't receive any failed transactions on a mainnet fork, for each case: bLUSD, LUSD and both. |
| const minBLusdAmount = withdrawal.get(BLusdAmmTokenIndex.BLUSD)?.mul(1 - curveSlippage); | ||
| const minLusdAmount = withdrawal.get(BLusdAmmTokenIndex.LUSD)?.mul(1 - curveSlippage); | ||
|
|
||
| if (minBLusdAmount === undefined || minBLusdAmount === Decimal.ZERO) return; |
There was a problem hiding this comment.
Under which conditions could this happen? Would the user get any error?
There was a problem hiding this comment.
In theory it shouldn't happen since withdrawal should be initialized by the time handleConfirmPressed is invoked, however this check ensures that for whatever potential reason withdrawal is zero (e.g. a future dev mistake, or unknown bug), this function won't let the user withdraw with a 0 value.
| }); | ||
| } | ||
| }; | ||
| };; |
There was a problem hiding this comment.
I’m curious, why does it need two “;”?
edmulraney
force-pushed
the
fix-blusd-lp-sandwich-attack
branch
from
2246a3f to
5b3229e
Compare
edmulraney
changed the title
Specify min out parameters for Curve liquidity withdrawals.