Fix notify (#475)

* fix notification delay

* added copilot suggestions

Author: ygerlach

src/Utility/OSDNotify.vala

@@ -70,8 +70,8 @@ public class OSDNotify : GLib.Object {
 
 				string s = "notify-send -t %d -u %s -i %s \"%s\" \"%s\" -h %s".printf(
 					durationMillis, urgency, "gtk-dialog-" + dialog_type, title, message, hint);
-					
-				retVal = exec_sync (s, null, null);
+				
+				retVal = TeeJee.ProcessHelper.exec_user_async(s);
 
 				dt_last_notification = new DateTime.now_local();
 			}

src/Utility/TeeJee.Process.vala

@@ -202,6 +202,26 @@ namespace TeeJee.ProcessHelper{
 	    }
 	}
 
+	/**
+		executes a command as the "normal" unprivileged user async
+		may execute the command as root if the user could not be determined or the name could not be resolved
+	 */
+	public static int exec_user_async(string command) {
+		// find correct user
+		int uid = TeeJee.System.get_user_id();
+		string cmd = command;
+		if(uid > 0) {
+			// non root
+			string? user = TeeJee.System.get_username_from_uid(uid);
+			if(user != null) {
+				cmd = "pkexec --user %s env DISPLAY=$DISPLAY XAUTHORITY=$XAUTHORITY DBUS_SESSION_BUS_ADDRESS=$DBUS_SESSION_BUS_ADDRESS ".printf(user) + cmd;
+			}
+		}
+
+		log_debug(cmd);
+		return TeeJee.ProcessHelper.exec_script_async(cmd);
+	}
+
 	public string? save_bash_script_temp (string commands, string? script_path = null,
 		bool force_locale = true, bool supress_errors = false){
 

src/Utility/TeeJee.System.vala

@@ -67,7 +67,11 @@ namespace TeeJee.System{
 
 	public string? get_username_from_uid(int user_id){
 		unowned Posix.Passwd? pw = Posix.getpwuid(user_id);
-		return pw?.pw_name;
+		string? outvalue = pw?.pw_name;
+		if(null == outvalue) {
+			log_error("Could not get username for uid %d".printf(user_id));
+		}
+		return outvalue;
 	}
 
 	// system ------------------------------------
@@ -90,19 +94,7 @@ namespace TeeJee.System{
 
 		string cmd = "xdg-open '%s'".printf(escape_single_quote(file));
 
-		// find correct user
-		int uid = get_user_id();
-		if(uid > 0) {
-			// non root
-			string? user = get_username_from_uid(uid);
-			if(user != null) {
-				cmd = "pkexec --user %s env DISPLAY=$DISPLAY XAUTHORITY=$XAUTHORITY DBUS_SESSION_BUS_ADDRESS=$DBUS_SESSION_BUS_ADDRESS ".printf(user) + cmd;
-			}
-		}
-
-		log_debug(cmd);
-		int status = exec_script_async(cmd);
-		return (status == 0);
+		return exec_user_async(cmd) == 0;
 	}
 
 	public bool exo_open_folder (string dir_path, bool xdg_open_try_first = true){