Skip to content

Commit cd05a0e

Browse files
Cyrill Gorcunovdavem330
Cyrill Gorcunov
authored andcommitted
net: ip, raw_diag -- Fix socket leaking for destroy request
In raw_diag_destroy the helper raw_sock_get returns with sock_hold call, so we have to put it then. CC: David S. Miller <davem@davemloft.net> CC: Eric Dumazet <eric.dumazet@gmail.com> CC: David Ahern <dsa@cumulusnetworks.com> CC: Andrey Vagin <avagin@openvz.org> CC: Stephen Hemminger <stephen@networkplumber.org> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org> Acked-by: David Ahern <dsa@cumulusnetworks.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 1719723 commit cd05a0e

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

net/ipv4/raw_diag.c

+4-1
Original file line numberDiff line numberDiff line change
@@ -205,11 +205,14 @@ static int raw_diag_destroy(struct sk_buff *in_skb,
205205
{
206206
struct net *net = sock_net(in_skb->sk);
207207
struct sock *sk;
208+
int err;
208209

209210
sk = raw_sock_get(net, r);
210211
if (IS_ERR(sk))
211212
return PTR_ERR(sk);
212-
return sock_diag_destroy(sk, ECONNABORTED);
213+
err = sock_diag_destroy(sk, ECONNABORTED);
214+
sock_put(sk);
215+
return err;
213216
}
214217
#endif
215218

0 commit comments

Comments
 (0)