Skip to content

Commit 786b311

Browse files
Hugh Dickinstorvalds
Hugh Dickins
authored andcommitted
mm: remove nrexceptional from inode: remove BUG_ON
clear_inode()'s BUG_ON(!mapping_empty(&inode->i_data)) is unsafe: we know of two ways in which nodes can and do (on rare occasions) get left behind. Until those are fixed, do not BUG_ON() nor even WARN_ON(). Yes, this will then leak those nodes (or the next user of the struct inode may use them); but this has been happening for years, and the new BUG_ON(!mapping_empty) was only guilty of revealing that. A proper fix will follow, but no hurry. Link: https://lkml.kernel.org/r/alpine.LSU.2.11.2104292229380.16080@eggly.anvils Signed-off-by: Hugh Dickins <hughd@google.com> Cc: Matthew Wilcox <willy@infradead.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 8bc3c48 commit 786b311

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

fs/inode.c

+8-1
Original file line numberDiff line numberDiff line change
@@ -529,7 +529,14 @@ void clear_inode(struct inode *inode)
529529
*/
530530
xa_lock_irq(&inode->i_data.i_pages);
531531
BUG_ON(inode->i_data.nrpages);
532-
BUG_ON(!mapping_empty(&inode->i_data));
532+
/*
533+
* Almost always, mapping_empty(&inode->i_data) here; but there are
534+
* two known and long-standing ways in which nodes may get left behind
535+
* (when deep radix-tree node allocation failed partway; or when THP
536+
* collapse_file() failed). Until those two known cases are cleaned up,
537+
* or a cleanup function is called here, do not BUG_ON(!mapping_empty),
538+
* nor even WARN_ON(!mapping_empty).
539+
*/
533540
xa_unlock_irq(&inode->i_data.i_pages);
534541
BUG_ON(!list_empty(&inode->i_data.private_list));
535542
BUG_ON(!(inode->i_state & I_FREEING));

0 commit comments

Comments
 (0)