NFS: Remove unnecessary inode lock in nfs_fsync_dir()

Trond Myklebust · amschuma-ntap · commit 11decaf8127b · 2020-11-12T10:41:26.000-05:00
nfs_inc_stats() is already thread-safe, and there are no other reasons
to hold the inode lock here.

Signed-off-by: Trond Myklebust &lt;trond.myklebust@hammerspace.com&gt;
Signed-off-by: Anna Schumaker &lt;Anna.Schumaker@Netapp.com&gt;
diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
@@ -997,13 +997,9 @@ static loff_t nfs_llseek_dir(struct file *filp, loff_t offset, int whence)
 static int nfs_fsync_dir(struct file *filp, loff_t start, loff_t end,
 			 int datasync)
 {
-	struct inode *inode = file_inode(filp);
-
 	dfprintk(FILE, "NFS: fsync dir(%pD2) datasync %d\n", filp, datasync);
 
-	inode_lock(inode);
-	nfs_inc_stats(inode, NFSIOS_VFSFSYNC);
-	inode_unlock(inode);
+	nfs_inc_stats(file_inode(filp), NFSIOS_VFSFSYNC);
 	return 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -997,13 +997,9 @@ static loff_t nfs_llseek_dir(struct file *filp, loff_t offset, int whence)`
`997`	`997`	`static int nfs_fsync_dir(struct file *filp, loff_t start, loff_t end,`
`998`	`998`	`int datasync)`
`999`	`999`	`{`
`1000`		`- struct inode *inode = file_inode(filp);`
`1001`		`-`
`1002`	`1000`	`dfprintk(FILE, "NFS: fsync dir(%pD2) datasync %d\n", filp, datasync);`
`1003`	`1001`
`1004`		`- inode_lock(inode);`
`1005`		`- nfs_inc_stats(inode, NFSIOS_VFSFSYNC);`
`1006`		`- inode_unlock(inode);`
	`1002`	`+ nfs_inc_stats(file_inode(filp), NFSIOS_VFSFSYNC);`
`1007`	`1003`	`return 0;`
`1008`	`1004`	`}`
`1009`	`1005`