Skip to content

Commit 05da1f6

Browse files
committed
Merge tag 'iomap-5.13-merge-3' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux
Pull more iomap updates from Darrick Wong: "Remove the now unused 'io_private' field from struct iomap_ioend, for a modest savings in memory allocation" * tag 'iomap-5.13-merge-3' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux: iomap: remove unused private field from ioend
2 parents af12070 + 6e55249 commit 05da1f6

File tree

3 files changed

+3
-11
lines changed

3 files changed

+3
-11
lines changed

fs/iomap/buffered-io.c

+1-6
Original file line numberDiff line numberDiff line change
@@ -1134,9 +1134,7 @@ iomap_ioend_can_merge(struct iomap_ioend *ioend, struct iomap_ioend *next)
11341134
}
11351135

11361136
void
1137-
iomap_ioend_try_merge(struct iomap_ioend *ioend, struct list_head *more_ioends,
1138-
void (*merge_private)(struct iomap_ioend *ioend,
1139-
struct iomap_ioend *next))
1137+
iomap_ioend_try_merge(struct iomap_ioend *ioend, struct list_head *more_ioends)
11401138
{
11411139
struct iomap_ioend *next;
11421140

@@ -1148,8 +1146,6 @@ iomap_ioend_try_merge(struct iomap_ioend *ioend, struct list_head *more_ioends,
11481146
break;
11491147
list_move_tail(&next->io_list, &ioend->io_list);
11501148
ioend->io_size += next->io_size;
1151-
if (next->io_private && merge_private)
1152-
merge_private(ioend, next);
11531149
}
11541150
}
11551151
EXPORT_SYMBOL_GPL(iomap_ioend_try_merge);
@@ -1236,7 +1232,6 @@ iomap_alloc_ioend(struct inode *inode, struct iomap_writepage_ctx *wpc,
12361232
ioend->io_inode = inode;
12371233
ioend->io_size = 0;
12381234
ioend->io_offset = offset;
1239-
ioend->io_private = NULL;
12401235
ioend->io_bio = bio;
12411236
return ioend;
12421237
}

fs/xfs/xfs_aops.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ xfs_end_io(
146146
while ((ioend = list_first_entry_or_null(&tmp, struct iomap_ioend,
147147
io_list))) {
148148
list_del_init(&ioend->io_list);
149-
iomap_ioend_try_merge(ioend, &tmp, NULL);
149+
iomap_ioend_try_merge(ioend, &tmp);
150150
xfs_end_ioend(ioend);
151151
}
152152
}

include/linux/iomap.h

+1-4
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,6 @@ struct iomap_ioend {
198198
struct inode *io_inode; /* file being written to */
199199
size_t io_size; /* size of the extent */
200200
loff_t io_offset; /* offset in the file */
201-
void *io_private; /* file system private data */
202201
struct bio *io_bio; /* bio being built */
203202
struct bio io_inline_bio; /* MUST BE LAST! */
204203
};
@@ -234,9 +233,7 @@ struct iomap_writepage_ctx {
234233

235234
void iomap_finish_ioends(struct iomap_ioend *ioend, int error);
236235
void iomap_ioend_try_merge(struct iomap_ioend *ioend,
237-
struct list_head *more_ioends,
238-
void (*merge_private)(struct iomap_ioend *ioend,
239-
struct iomap_ioend *next));
236+
struct list_head *more_ioends);
240237
void iomap_sort_ioends(struct list_head *ioend_list);
241238
int iomap_writepage(struct page *page, struct writeback_control *wbc,
242239
struct iomap_writepage_ctx *wpc,

0 commit comments

Comments
 (0)