-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Booting/testing something in CI #19
base: master
Are you sure you want to change the base?
Conversation
1b28512
to
d0cd661
Compare
This is hitting issues with the |
ff41e99
to
7636f01
Compare
Early indications are that In moby/tool#191 I observed the initial RAM usage before my changes was 6.7GB which seems consistent with getting SITH on a 6GB limit. I also noted that |
8e10db4
to
a22eacb
Compare
Please sign your commits following these rules: $ git clone -b "ci-boot-something" git@github.com:ijc/linuxkit-kubernetes.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354248512
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f Amending updates the existing PR. You DO NOT need to open a new one. |
a22eacb
to
14811e6
Compare
41aac3c
to
6166887
Compare
Signed-off-by: Ian Campbell <ijc@docker.com>
6c35830
to
4975d44
Compare
Signed-off-by: Ian Campbell <ijc@docker.com>
Signed-off-by: Ian Campbell <ijc@docker.com>
Signed-off-by: Ian Campbell <ijc@docker.com>
Signed-off-by: Ian Campbell <ijc@docker.com>
Signed-off-by: Ian Campbell <ijc@docker.com>
Signed-off-by: Ian Campbell <ijc@docker.com>
Signed-off-by: Ian Campbell <ijc@docker.com>
044c425
to
b18fb4c
Compare
b18fb4c
to
03c64c8
Compare
03c64c8
to
734f583
Compare
734f583
to
b71d752
Compare
b71d752
to
dec667c
Compare
Signed-off-by: Ian Campbell <ijc@docker.com>
dec667c
to
e342651
Compare
We have no MacOS workers in circle (seems it is a paid only feature) so the jobs just hang forever waiting to be assigned. It's been suggested we could try using the same gcp account as the linuxkit/linuxkit CI and use |
This makes sense. The only concern that I have is how long would it take to upload a build from Circle to GCP... We would also have to cleanup image, as I'm pretty sure they charge for storing them. The alternative would be to build and run on a VM that supports nested virt. IIRC there is a new instance type GCP that supports nested virt. |
@rn is experimenting with the nested virt stuff on the main linuxkit repo now, will wait and see how he gets on. It might indeed be too much data to upload for each PR, may turn out better to deploy a VM to build the images whether we then test them nested or in a new VM altogether. |
Also, if use nested virt, it means someone can reproduce the tests locally very easily, we could even provide a generalised script for folks to re-use in private LinuxKit projects. Just reiterating what I've said earlier... |
linuxkit/linuxkit#2871 has the right runes for enabling nested virt. The image needs to have a "special license" (some string in the Licenses field) and the instance needs to be Haswell or newer. |
Very incomplete right now, will work on it as time allows.